Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Czhu fix parse rmats #724

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Czhu fix parse rmats #724

merged 4 commits into from
Apr 25, 2023

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Apr 25, 2023

Description

Fixing 3 things here.

  1. The skip junctions of SE were not handled correctly.
  2. The function that identifies a transcript being mRNA_end_NF did not do its job. This is not related to AS.
  3. I added a check in the beginning of each cli to make sure the output files are writable, to avoid waiting for hours to find out the output file has no write permission.

So because of 2, we may have to rerun the SNV only for CPCG samples for benchmark again. I tried CPCG0100 and the difference is pretty small.

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

zhuchcn added 2 commits April 25, 2023 16:43
… files have write permission at the very beginning to avoid wasting time running the program
@zhuchcn zhuchcn marked this pull request as ready for review April 25, 2023 12:04
@zhuchcn zhuchcn requested a review from lydiayliu April 25, 2023 12:04
moPepGen/cli/summarize_fasta.py Show resolved Hide resolved
@lydiayliu
Copy link
Collaborator

Closes #671?

@zhuchcn zhuchcn linked an issue Apr 25, 2023 that may be closed by this pull request
@zhuchcn zhuchcn merged commit a234504 into main Apr 25, 2023
@zhuchcn zhuchcn deleted the czhu-fix-parse-rmats branch April 25, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check output path before launching mpg
2 participants