Restrict access to activity log #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowesn
force-pushed
the
408/restrict-activity-log-access
branch
2 times, most recently
from
d5f0d54 to
d9c6ef5
Compare
crowesn
force-pushed
the
408/restrict-activity-log-access
branch
from
d9c6ef5 to
da9e585
Compare
hortongn
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #408
We use CanCan to authorize actions in the app and neglected to include the activity log in the abilities set.
This PR restricts activity log access to standard and admin users using abilities model.
Also fleshes out specs for admin abilities.