Clean up Fix class and remove reason property from class decl #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimakarimipour
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cleanup that is required before the upcoming major PR that adds support for taint checker inference.
Changes:
Removed the reason property from the Fix class. Previously, this field stored the set of errors associated with each fix. However, this information can be derived directly from the set of errors itself.
Refactored the code to remove redundant storage, ensuring a cleaner and more efficient design.
Rationale:
The reason property is redundant as the same information is accessible through the error set. This refactoring simplifies the codebase and eliminates unnecessary complexity, making future updates, including the taint checker inference integration, easier to manage.