Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Spotless for formatting #249

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Switch to Spotless for formatting #249

merged 2 commits into from
Oct 8, 2024

Conversation

msridhar
Copy link
Member

@msridhar msridhar commented Oct 8, 2024

We were using another plugin for formatting before, but Spotless is maintained. Also we update to latest GJF version, which tweaks the formatting a bit.

No need to merge this immediately if it causes lots of conflicts in outstanding PRs. We can always do it later and re-run the formatting pass.

Fixes #248

@nimakarimipour
Copy link
Member

@msridhar Thank you very much for the PR. I have no ongoing PR at the moment. Will merge it now.

@nimakarimipour nimakarimipour merged commit 6783200 into master Oct 8, 2024
7 checks passed
@nimakarimipour nimakarimipour deleted the spotless-gjf branch October 8, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enfore Google Java Format via Spotless
2 participants