This repository has been archived by the owner on Nov 25, 2021. It is now read-only.
Two small changes to add support for TF 1.0 for YOLO (vehicle-detection/darkflow/) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The if-statement is to general, by including the complete version number we assure that the correct key is loaded for TF 1.0 as well.
In TF 1.0 the order for the variables in tf.concat are changed. By explicitly naming the inputs we ensure that the code works for all versions.
Optimised code for TF 1.0.1 as well. We only check major and minor version number now. Everything < 0.11 uses different key name
| if int(v) < 12: key = 'initializers' | ||
| v_ma = tf.__version__.split('.')[0] | ||
| v_mi = tf.__version__.split('.')[1] | ||
| if int(v_ma) < 1 & int(v_mi) < 12: key = 'initializers' |
There was a problem hiding this comment.
int(v_ma) < 1 & int(v_mi) < 12 , how can at a time value be less then 1 and 12, then second condition has no meaning.
is the actual condition like int(v_ma) > 1 & int(v_mi) < 12
There was a problem hiding this comment.
@kiranvdhotre Please pay attention to the variable names. One is for the version's major value and the other for the minor value, v_ma and v_mi respectively.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for TF 1.0 for YOLO detector for vehicle detection. By making 2 small changes in convolution.py and simple.py we ensure the code runs for all versions of TF: