Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Command is invalid, when I install emoji-combobox in platejs.org #3203

Merged
merged 1 commit into from
May 18, 2024

Conversation

jijiseong
Copy link
Contributor

@jijiseong jijiseong commented May 18, 2024

Description

issue: #3202

When isManual is false, installCommands.components returns unexpected value.

`${isManual && ' tooltip}'` // returns 'false'

So, I changed the code as below

`${isManual ? ' tooltip' : ''}` // returns ''

It's the result!
image

Copy link

changeset-bot bot commented May 18, 2024

⚠️ No Changeset found

Latest commit: cdb6e83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 8:34am

@jijiseong jijiseong changed the title Fix: invalid command Fix: Command is invalid, when I install emoji-combobox in platejs.org May 18, 2024
@felixfeng33
Copy link
Collaborator

felixfeng33 commented May 18, 2024

@jijiseong Thank you for your help!

@felixfeng33
Copy link
Collaborator

@zbeyens why the CI will blocked?

@zbeyens zbeyens merged commit dcd80c3 into udecode:main May 18, 2024
2 checks passed
@zbeyens
Copy link
Member

zbeyens commented May 18, 2024

Sometimes it needs approval

@jijiseong jijiseong deleted the fix/add-components-command branch May 18, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants