Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some refactoring overall #62

Open
7 of 9 tasks
adamgulde opened this issue Nov 14, 2024 · 0 comments
Open
7 of 9 tasks

Some refactoring overall #62

adamgulde opened this issue Nov 14, 2024 · 0 comments
Assignees
@rdg922 @adamgulde
Labels
documentation Improvements or additions to documentation medium Simple enough issue but probably overlooked during initial development. MVP Required for minimum viable product (ideal deadline: Dec. 11)

Comments

@adamgulde
Copy link
Collaborator

adamgulde commented Nov 14, 2024 •
edited
Loading

If you have any (minor or major!) changes to the codebase comment here

  • Monopoly.py match/case change to enum for property
  • All player information should be accessed / retrieved from banker.py clients list.
    • bal command in player.py get_input() needs to access from banker
    • deed command likewise
  • Player should be asked name at start of game instead of banker. See handshake function in banker.py
  • All long code for modules (e.g. "elif data.startswith('ttt')" in banker.py handle_data() should be moved to an independent function to handle.
  • Calc module needs to be removed from player.py to modules.py or its own file in modules_directory
  • Move player.py initialize() into networking.py
  • Remove print_board() from screenspace.py
  • Remove testclient.py
  • Remove testserver.py
@adamgulde adamgulde added documentation Improvements or additions to documentation medium Simple enough issue but probably overlooked during initial development. MVP Required for minimum viable product (ideal deadline: Dec. 11) labels Nov 14, 2024
adamgulde added a commit to adamgulde/TERMINALMONOPOLY that referenced this issue Nov 15, 2024
@adamgulde
refactor: added comments, cleaned up code.
8753e87 
Addressed several issues with the codebase. See
issue ufosc#62 for some of the solved details.

- banker.py
-- Most notably added a more robust unit testing
manager. The user can create custom unit tests or
choose from a list of pre-made tests, which are
now detailed as they print to the screen.
-- Moved battleship and tictactoe handling from
handle_data() to their own respective functions.
-- Added validate_name()
-- Added comments, cleaned up code.
- modules.py
-- Moved calculator module from player.py to
modules.py. Streamlined a bit.
- monopoly.py
-- Fixed printing bug where the player's name
was not being printed as player.order instead of
player.name.
- networking.py
-- Added comments, cleaned up code.
- player_class.py
-- Renamed class symbol  from Player to
MonopolyPlayer to clear up some ambiguity. This is
 reflected in cards.py, board.py, monopoly.py
- player.py
-- Added inputting player name during
initialization.
-- Added bal function to get balance from banker.
-- Moved calculator module to modules.py
-- Added comments, cleaned up code.
- screenspace.py
-- Removed print_board()
-- Added whitelist to get_valid_int()
-- Added comments, cleaned up code.
- Deleted testclient.py, testserver.py
- Updated .gitignore
@adamgulde adamgulde mentioned this issue Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdg922 rdg922

@adamgulde adamgulde

Labels
documentation Improvements or additions to documentation medium Simple enough issue but probably overlooked during initial development. MVP Required for minimum viable product (ideal deadline: Dec. 11)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rdg922 @adamgulde