fix(ui): fix header alignment (#162)

ui5-community · Apr 26, 2022 · 1696d5a · 1696d5a
1 parent 2f371dd
commit 1696d5a
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 23 deletions.
diff --git a/packages/ui/src/view/App.view.xml b/packages/ui/src/view/App.view.xml
@@ -1,6 +1,34 @@
 <mvc:View controllerName="org.openui5.bestofui5.controller.App" xmlns:mvc="sap.ui.core.mvc" displayBlock="true" xmlns="sap.m" xmlns:ui5cc="org.openui5.bestofui5.control" xmlns:core="sap.ui.core">
   <App>
     <Page id="page" title="{i18n>title}" titleAlignment="Center" class="openui5header">
+      <headerContent>
+        <OverflowToolbar style="Clear">
+          <ToolbarSpacer />
+          <Button
+            class="sapUiTinyMargin"
+            core:require="{ sapMLib: 'sap/m/library' }"
+            text="Add your own package"
+            type="Emphasized"
+            icon="sap-icon://add-product"
+            press="sapMLib.URLHelper.redirect('https://github.com/ui5-community/bestofui5-website/issues/new?assignees=&amp;labels=new%20package&amp;template=new_package.md&amp;title=Add%20new%20package:', true)"
+          >
+            <layoutData>
+              <OverflowToolbarLayoutData priority="{= ${device>/system/phone} === true ? 'AlwaysOverflow' : 'NeverOverflow' }" group="1" />
+            </layoutData>
+          </Button>
+          <Button
+            class="sapUiTinyMargin"
+            core:require="{ sapMLib: 'sap/m/library' }"
+            type="Neutral"
+            icon="sap-icon://font-awesome-icons/github"
+            press="sapMLib.URLHelper.redirect('https://github.com/ui5-community/bestofui5-website#readme', true)"
+          >
+            <layoutData>
+              <OverflowToolbarLayoutData priority="{= ${device>/system/phone} === true ? 'AlwaysOverflow' : 'NeverOverflow' }" group="1" />
+            </layoutData>
+          </Button>
+        </OverflowToolbar>
+      </headerContent>
       <subHeader>
         <OverflowToolbar class="doNotRoundMyToolBar">
           <core:Fragment id="LinkHeader" fragmentName="org.openui5.bestofui5.view.LinkHeader" type="XML" />

diff --git a/packages/ui/src/view/LinkHeader.fragment.xml b/packages/ui/src/view/LinkHeader.fragment.xml
@@ -33,27 +33,4 @@
     </layoutData>
   </Button>
   <ToolbarSpacer />
-  <Button
-    class="sapUiTinyMargin"
-    core:require="{ sapMLib: 'sap/m/library' }"
-    text="Add your own package"
-    type="Emphasized"
-    icon="sap-icon://add-product"
-    press="sapMLib.URLHelper.redirect('https://github.com/ui5-community/bestofui5-website/issues/new?assignees=&amp;labels=new%20package&amp;template=new_package.md&amp;title=Add%20new%20package:', true)"
-  >
-    <layoutData>
-      <OverflowToolbarLayoutData priority="Low" group="2" />
-    </layoutData>
-  </Button>
-  <Button
-    class="sapUiTinyMargin"
-    core:require="{ sapMLib: 'sap/m/library' }"
-    type="Neutral"
-    icon="sap-icon://font-awesome-icons/github"
-    press="sapMLib.URLHelper.redirect('https://github.com/ui5-community/bestofui5-website', true)"
-  >
-    <layoutData>
-      <OverflowToolbarLayoutData priority="Low" group="2" />
-    </layoutData>
-  </Button>
 </core:FragmentDefinition>