chore(infra): only lint staged files

[petermuessig]

No description provided.

[marianfoo]

just had to change gh workflow
i´m not sure how yarn workspaces run build works, is it alway alphabetical? crawl -> ui
if we can make that sure we can run in workflow just this one command to run crawl and build ui

[petermuessig]

AFAICS, it runs the build in the alphabetical order. Due to the pattern packages/* it uses the order how the pattern resolves the projects. If you want a different order, you can specify the workspaces directly via packages/ui and packages/crawler in the workspaces configuration of the root package.json.

[marianfoo]

Just for me to understand:
during commit prettier is executed?

on push what is executed?
i see → No staged files found here, but on push there are never staged files, right?

[petermuessig]

That's right, @marianfoo - I missed to adopt to move this to the pre-commit phase. The pre-push only made sense because of the full lint run.

[petermuessig]

Only the lint:commit makes sense for the pre-push hook as we want to only validate the last commit message which is pushed. We can also agree to ensure the commit message validation for all intermediate commits as well?

[marianfoo]

Only the lint:commit makes sense for the pre-push hook as we want to only validate the last commit message which is pushed. We can also agree to ensure the commit message validation for all intermediate commits as well?

Because of the merge commit it is enough to lint the last commit message.
It´s easier to commit then change last commit message.

[petermuessig]

Change is good to go - can finally discuss it tomorrow morning...

[marianfoo]

will do!

[marianfoo]

LGTM!

[marianfoo]

this will run pretty-quick --staged for all workspaces
it seems this is not divided by workspace and will just prettier all files, not just for ui/crawler
so the command with the same result is then executed twice here
the previous command was already ok