Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

add pressTile step #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add pressTile step #1

wants to merge 3 commits into from

Conversation

vl-leon
Copy link
Collaborator

@vl-leon vl-leon commented Jun 28, 2024

No description provided.

@vl-leon vl-leon requested a review from vobu June 28, 2024 16:32
lib/index.js Outdated
@@ -0,0 +1,6 @@
let { Given, When, Then } = require('@cucumber/cucumber');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

essentially the same const vs let remark that I already left in the wdi5-fe-selectors repo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

lib/index.js Outdated
let { Given, When, Then } = require('@cucumber/cucumber');
let lib = require('wdi5-fe-selectors');

Given('we press tile {string}', async function (name) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any need for the this-scoped function as opposed to async (name) => {?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done - no reason currently

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants