fixup! feat: Add Pagination component

uktrade · Nov 1, 2019 · 01280f1 · 01280f1
1 parent 99d2a00
commit 01280f1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/pagination/Pagination.jsx b/src/pagination/Pagination.jsx
@@ -72,7 +72,7 @@ const StyledPagesTruncation = styled('span')`
 `
 
 function Pagination({ totalPages, activePage, onPageClick, getPageUrl }) {
-  const visiblePieces = computeVisiblePieces(totalPages, activePage, 5)
+  const visiblePieces = computeVisiblePieces(totalPages, activePage)
 
   if (totalPages === 1) {
     return null

diff --git a/src/pagination/computeVisiblePieces.js b/src/pagination/computeVisiblePieces.js
@@ -1,4 +1,5 @@
 import {
+  DEFAULT_MAX_PAGE_NUMBER_LINKS,
   PAGINATION_PIECE_ELLIPSIS,
   PAGINATION_PIECE_NEXT,
   PAGINATION_PIECE_PAGE_NUMBER,
@@ -7,8 +8,8 @@ import {
 
 function computeVisiblePieces(
   numberOfPages,
-  activePage = 1,
-  maxPageNumbers = 5
+  activePage,
+  maxPageNumbers = DEFAULT_MAX_PAGE_NUMBER_LINKS
 ) {
   const visiblePieces = []
   let lowerLimit = activePage

diff --git a/src/pagination/constants.js b/src/pagination/constants.js
@@ -2,3 +2,5 @@ export const PAGINATION_PIECE_PREVIOUS = 'previous'
 export const PAGINATION_PIECE_ELLIPSIS = 'ellipsis'
 export const PAGINATION_PIECE_PAGE_NUMBER = 'page-number'
 export const PAGINATION_PIECE_NEXT = 'next'
+
+export const DEFAULT_MAX_PAGE_NUMBER_LINKS = 5