Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug of code #185

Closed
zhanhb opened this issue Mar 31, 2019 · 2 comments
Closed

Possible bug of code #185

zhanhb opened this issue Mar 31, 2019 · 2 comments
Assignees
@ultraq
Labels
bug

Comments

@zhanhb
Copy link
Contributor

zhanhb commented Mar 31, 2019

thymeleaf-layout-dialect/source/nz/net/ultraq/thymeleaf/decorators/strategies/GroupingStrategy.groovy

Line 71 in 9e1d3b9

return positions > 2 ? 2 : 1

Where is the definition of the variable positions?
@ultraq ultraq self-assigned this Mar 31, 2019
@ultraq ultraq added the bug label Mar 31, 2019
@ultraq
Copy link
Owner

ultraq commented Mar 31, 2019

Looks like a copy/paste error on my part. That's supposed to be headModel.size().

ultraq added a commit that referenced this issue Mar 31, 2019
@ultraq
Fix copy/paste bug, wrap some unit tests around it, #185
8cc00eb
@ultraq
Copy link
Owner

ultraq commented Mar 31, 2019

Fixed in 2.4.1-SNAPSHOT.

@ultraq ultraq closed this as completed Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ultraq ultraq

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ultraq @zhanhb