Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Groovy 3.x #202

Closed
wimdeblauwe opened this issue Mar 10, 2020 · 3 comments
Closed

Update to Groovy 3.x #202

wimdeblauwe opened this issue Mar 10, 2020 · 3 comments
Assignees

Comments

@wimdeblauwe
Copy link

This will avoid the problem of the reflective access warning (issue #188)

@ultraq ultraq added this to the Thymeleaf Layout Dialect 3 milestone Mar 11, 2020
@ultraq ultraq self-assigned this Mar 13, 2021
@ultraq ultraq modified the milestones: Thymeleaf Layout Dialect 3, 2.6.0 Mar 13, 2021
@mjeffrey
Copy link

It'd be nice to have this before Java 17 where this warning changes to an error (java17 removes the possibility to ignore the error).

See https://blogs.oracle.com/javamagazine/java-runtime-encapsulation-internals

@ultraq ultraq modified the milestones: 2.6.0, Thymeleaf Layout Dialect 3 Jul 4, 2021
@ultraq ultraq closed this as completed in 4c02342 Jul 4, 2021
@ultraq
Copy link
Owner

ultraq commented Jul 4, 2021

Oh hey, thanks for letting me know that this was finally gonna be clamped down in Java 17. I've had a Groovy 3 branch that needed some cleaning up to work correctly, so I've completed that work which closes this issue and am aiming for it to be in the next major version.

If anybody coming across this issue is interested, there is a 3.0.0-SNAPSHOT version of the layout dialect that contains this upgrade.

ultraq added a commit that referenced this issue Jul 4, 2021
@mjeffrey
Copy link

mjeffrey commented Jul 5, 2021

Thank you! Will try out the snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants