Code

Flamegraphs#137

Code

Open

brainstorm wants to merge 100 commits intomainumccr/htsget-rs:mainfrom flamegraphsumccr/htsget-rs:flamegraphsCopy head branch name to clipboard

+730-424

Commits

Commits on Jun 14, 2022

• Trim the whole GHA, use https://github.com/umccr/reusable-github-actions

  brainstorm

  committed
  d6f9dd5

  Copy full SHA for d6f9dd5

• Repoint reusable workflows as per https://github.com/umccr/htsget-rs/actions/runs/2493214340

  brainstorm

  committed
  e2cb2a5

  Copy full SHA for e2cb2a5

• Comment indirection

  brainstorm

  committed
  dea2bef

  Copy full SHA for dea2bef

• derive Eq along w/ PartialEq: https://github.com/umccr/htsget-rs/runs/6875010856?check_suite_focus=true#step:5:455

  brainstorm

  committed
  1926d93

  Copy full SHA for 1926d93

• Comment the test and benchmarks for now, need to implement dependencies w/ reusable workflows, see https://stackoverflow.com/questions/58457140/dependencies-between-workflows-on-github-actions and h…

  Show description for 1c40a03
  brainstorm

  committed
  1c40a03

  Copy full SHA for 1c40a03

Commits on Jun 15, 2022

• PartialEq, Eq errors

  brainstorm

  committed
  3afe447

  Copy full SHA for 3afe447

• Hopefully done with that Eq lint?

  brainstorm

  committed
  28345c5

  Copy full SHA for 28345c5

Commits on Jun 16, 2022

• Remove stray char in Cloud

  brainstorm

  committed
  05b528f

  Copy full SHA for 05b528f

Commits on Jun 20, 2022

• Avoid duplicate CI runs

  brainstorm

  committed
  a63c889

  Copy full SHA for a63c889

• Check passes, let's go for testing phase

  brainstorm

  committed
  dd4c794

  Copy full SHA for dd4c794

• Add job dependencies and drafting release module

  brainstorm

  committed
  dd60301

  Copy full SHA for dd60301

• Enable benchmarking phase

  brainstorm

  committed
  9d0c603

  Copy full SHA for 9d0c603

• Trigger run

  brainstorm

  committed
  fa3f2a3

  Copy full SHA for fa3f2a3

• Redundant comment

  brainstorm

  committed
  83fbc40

  Copy full SHA for 83fbc40

• Add a couple of TODO, test cargo-install for multiple crates at once

  brainstorm

  committed
  7772201

  Copy full SHA for 7772201

• Will use slim Rust container for

  brainstorm

  committed
  b2dbe78

  Copy full SHA for b2dbe78

• Need to get acquainted with conventional commits too, TODO

  brainstorm

  committed
  6d441a2

  Copy full SHA for 6d441a2

• Not fully convinced about shipping Docker too for devs, but giving it a go

  brainstorm

  committed
  52cb45d

  Copy full SHA for 52cb45d

Commits on Jun 21, 2022

• Adjust timing and number of samples to avoid criterion warnings/runouts, both locally and on the target CI environment (GHA).

  brainstorm

  committed
  44a7ac8

  Copy full SHA for 44a7ac8

• Benches closer to plots with this PR

  brainstorm

  committed
  56dcdd8

  Copy full SHA for 56dcdd8

• Original htsnexus implementation is gone from DNANexus, @mlin? /cc @ohofmann

  brainstorm

  committed
  b13c6f9

  Copy full SHA for b13c6f9

Commits on Jun 23, 2022

• Commits are non-convetional still, but let's try the request/search benchmarks and see if release PR is working

  brainstorm

  committed
  2c6a383

  Copy full SHA for 2c6a383

• Move rusable bits away from this repo

  brainstorm

  committed
  358baf2

  Copy full SHA for 358baf2

• Release should depend on benchmarking regressions too

  brainstorm

  committed
  f17f51b

  Copy full SHA for f17f51b

Commits on Dec 14, 2022

• Merge branch 'main' into better_ci

  brainstorm

  committed
  e499902

  Copy full SHA for e499902

• futures.push_back might have been deprecated? Switching to .push

  brainstorm

  committed
  514dff4

  Copy full SHA for 514dff4

Commits on Dec 15, 2022

• Inline format arguments (make clippy happy)

  brainstorm

  committed
  acb549c

  Copy full SHA for acb549c

• Cargo fmt

  brainstorm

  committed
  157b46b

  Copy full SHA for 157b46b

• Back pedal on push vs push_back (the former actually being the one being deprecated :-S)... more inline format clippy warnings that do not show locally despite cargo clean-ing and making sure same …

  Show description for c9b92ce
  brainstorm

  committed
  c9b92ce

  Copy full SHA for c9b92ce

• More inline format strings

  brainstorm

  committed
  251771d

  Copy full SHA for 251771d

• Fixup clippy on nightly too, not only stable

  brainstorm

  committed
  b573d0c

  Copy full SHA for b573d0c

Commits on Dec 16, 2022

• Ignore secrets and data

  brainstorm

  committed
  e755f42

  Copy full SHA for e755f42

• Clarify which lambda runtime we are using

  brainstorm

  committed
  52fae72

  Copy full SHA for 52fae72

• cargo clippy --fix for all features

  brainstorm

  committed
  272c1a4

  Copy full SHA for 272c1a4

• Cargo clippy --fix has been stabilised now

  brainstorm

  committed
  0fde7f3

  Copy full SHA for 0fde7f3

• Get rid of reusable workflows strategy

  brainstorm

  committed
  ae0c09d

  Copy full SHA for ae0c09d

Commits on Dec 19, 2022

• Focus on search benchmarks generation and storage

  brainstorm

  committed
  ad7ea00

  Copy full SHA for ad7ea00

• auto-push must be false when external-data-json-path is set since this action reads/writes the given JSON file and never pushes to remote

  brainstorm

  committed
  4b56ab1

  Copy full SHA for 4b56ab1

• Is the benchmark output being generated on stderr instead of stdout?

  brainstorm

  committed
  0ecf6d6

  Copy full SHA for 0ecf6d6

• Update secret accordingly, valid only for 1 year for now

  brainstorm

  committed
  bc0ac01

  Copy full SHA for bc0ac01

Commits on Dec 20, 2022

• Undo stdout/stderr redirection for search-benchmarks

  brainstorm

  committed
  6f7af68

  Copy full SHA for 6f7af68

• Going a bit more verbatim on github-action-benchmark docs, perhaps missed some assumption/convention?

  brainstorm

  committed
  28d4a0c

  Copy full SHA for 28d4a0c

• Where is the benchmark output.txt and why is it not found?

  brainstorm

  committed
  88f7caf

  Copy full SHA for 88f7caf

• Repeated htsget-rs/htsget-rs path segment in https://github.com/umccr/htsget-rs/actions/runs/3737593760/jobs/6342928802#step:9:17...

  brainstorm

  committed
  a5e36d2

  Copy full SHA for a5e36d2

• Hopefully correct path now/

  brainstorm

  committed
  9b256e9

  Copy full SHA for 9b256e9

Commits on Dec 21, 2022

• Hardcode output.txt path on the runner directory

  brainstorm

  committed
  0a1439d

  Copy full SHA for 0a1439d

Commits on Dec 22, 2022

• Test github-action-benchmark fork and cargo-criterion tool feature outlinedi n benchmark-action/github-action-benchmark#145

  brainstorm

  committed
  2239c74

  Copy full SHA for 2239c74

• Use the right branch for the forked action

  brainstorm

  committed
  94382af

  Copy full SHA for 94382af

Commits on Dec 23, 2022

• Forked GHA requires a runnable release to work

  brainstorm

  committed
  820fc92

  Copy full SHA for 820fc92

Commits on Jan 3, 2023

• Test custom cargo criterion release: does the GHA refer to tags/releases or branches?

  brainstorm

  committed
  a62fcc4

  Copy full SHA for a62fcc4

Commits on Jan 4, 2023

• Test all the changes introduced in the GHA

  brainstorm

  committed
  6b5bed7

  Copy full SHA for 6b5bed7

Commits on Jan 5, 2023

• Testing native benchmark report keeping

  brainstorm

  committed
  212fd88

  Copy full SHA for 212fd88

• Newer checkout migrates from deprecated Node12 to Node16

  brainstorm

  committed
  fd1cdff

  Copy full SHA for fd1cdff

• Merge branch 'main' into better_ci

  brainstorm

  committed
  d5b4c2e

  Copy full SHA for d5b4c2e

• Merge conflicts

  brainstorm

  committed
  5b09498

  Copy full SHA for 5b09498

• Add release-plz, first run

  brainstorm

  committed
  2c254a3

  Copy full SHA for 2c254a3

• error: all dependencies must have a version specified when publishing.

  brainstorm

  committed
  76ee9ad

  Copy full SHA for 76ee9ad

• [skip ci] Repoint dependencies to its respective repos instead of local paths, in preparation for (manual) crates.io release

  brainstorm

  committed
  76fe060

  Copy full SHA for 76fe060

• he remote server responded with an error: missing or empty metadata fields: description, license. Please see https://doc.rust-lang.org/cargo/reference/manifest.html for how to upload metadata

  brainstorm

  committed
  77b7772

  Copy full SHA for 77b7772

• Add missing licenses/descriptions pre-crates.io publishing [ci skip]

  brainstorm

  committed
  a9993b0

  Copy full SHA for a9993b0

• Adding the rest of attributes to avoid cargo publish warnings [ci skip]

  brainstorm

  committed
  a80128f

  Copy full SHA for a80128f

• Last metadata addition to avoid cargo publish warnings on htsget-test-utils crate [ci skip]

  brainstorm

  committed
  f06b2d2

  Copy full SHA for f06b2d2

Commits on Jan 6, 2023

• Rename htsget-http-actix -> htsget-actix, htsget-http-lambda -> htsget-lambda, htsget-http-core -> htsget-http, and htsget-test-utils -> htsget-test

  mmalenic

  committed
  a017b88

  Copy full SHA for a017b88

• Version bump all deps

  brainstorm

  committed
  98ba11a

  Copy full SHA for 98ba11a

• Better names for the lib side of this crate

  brainstorm

  committed
  208097d

  Copy full SHA for 208097d

• Cleanup before release as described in release-plz/action#14 (comment)

  brainstorm

  committed
  65fcc29

  Copy full SHA for 65fcc29

• Temporarily disable htsget-test as suggested by cargo maintainers

  brainstorm

  committed
  585485e

  Copy full SHA for 585485e

• Revert "Temporarily disable htsget-test as suggested by cargo maintainers"

  Show description for a9e9565
  brainstorm

  committed
  a9e9565

  Copy full SHA for a9e9565

• Stray fmt

  brainstorm

  committed
  b059b56

  Copy full SHA for b059b56

• Cargo clippy

  brainstorm

  committed
  c2d29f8

  Copy full SHA for c2d29f8

• This cargo fmt did not go through?

  brainstorm

  committed
  ecc1d00

  Copy full SHA for ecc1d00

Commits on Jan 7, 2023

• Only trigger on those branches as I'm testing, thanks @Marcoleni, let's see what happens now :)

  brainstorm

  committed
  48b16a0

  Copy full SHA for 48b16a0

• Split monolith GHA workflow into 3 actions, was running out of space by release

  brainstorm

  committed
  18b755b

  Copy full SHA for 18b755b

• Drop custom generate token for release-plz

  brainstorm

  committed
  b9a2fbd

  Copy full SHA for b9a2fbd

Commits on Jan 9, 2023

• No more than 1 level for tests and benchmarks [ci skip]

  brainstorm

  committed
  f365aed

  Copy full SHA for f365aed

• No target/criterion/<name_of_bench>/flamegraph.svg found :/

  brainstorm

  committed
  ccc6c27

  Copy full SHA for ccc6c27

• I suspect that the profiler only generates .svg's under Linux?

  brainstorm

  committed
  99ff449

  Copy full SHA for 99ff449

• Check if the flamegraph .svg has been generated alongside the JSONs

  brainstorm

  committed
  19e9c39

  Copy full SHA for 19e9c39

• wrong location/bench name?

  brainstorm

  committed
  736d0a7

  Copy full SHA for 736d0a7

Commits on Jan 10, 2023

• Rewire criterion function, just generates JSONs, no flamegraphs.svg yet :/ [ci skip]

  brainstorm

  committed
  a950199

  Copy full SHA for a950199

• Simplify cargo bench flamegraphs bench example a bit further and run it on Linux just in case pprof does not work on OSX? Also try to solve the --profile-time mystery argument on GHA

  brainstorm

  committed
  e63a1ff

  Copy full SHA for e63a1ff

Commits on Jan 15, 2023

• Merge deploy conflict(s)

  brainstorm

  committed
  6b3ad15

  Copy full SHA for 6b3ad15

Commits on Jan 16, 2023

• Merge branch 'better_ci' into flamegraphs

  brainstorm

  committed
  e3d8875

  Copy full SHA for e3d8875

• Merge branch 'main' into flamegraphs

  brainstorm

  authored
  7d6686d

  Copy full SHA for 7d6686d

• Switch from criterion-rs custom profiler strategy to cargo-flamegraphs crate

  brainstorm

  committed
  975df66

  Copy full SHA for 975df66

• Install cargo flamegraphs and match GHA names with jobs to avoid confusion

  brainstorm

  committed
  3c05343

  Copy full SHA for 3c05343

• Implicit --flamegraph will not be recognised by CLI

  brainstorm

  committed
  b3a2825

  Copy full SHA for b3a2825

• CI job failed with Linux-specific kernel settings, apply https://github.com/flamegraph-rs/flamegraph#enabling-perf-for-use-by-unprivileged-users

  brainstorm

  committed
  968f854

  Copy full SHA for 968f854

• Binary perfile data seems to be spewed on stdout for Linux, does not happen in DTrace under OSX? See: flamegraph-rs/flamegraph#248

  Show description for 4449b67
  brainstorm

  committed
  4449b67

  Copy full SHA for 4449b67

Commits on Jan 17, 2023

• What are the previous settings?

  brainstorm

  committed
  b18a45d

  Copy full SHA for b18a45d

Commits on May 12, 2023

• Merge branch 'main' into flamegraphs

  brainstorm

  authored
  482ee8e

  Copy full SHA for 482ee8e

Commits on May 16, 2023

• [ci skip] ResolveResponse trait having some weird import issues... refactoring into htsget-benchmarks after signing up for bencher.dev

  brainstorm

  committed
  c2d646b

  Copy full SHA for c2d646b

• fix(benchmarks): set correct feature flags for htsget dependencies

  mmalenic

  committed
  722bef8

  Copy full SHA for 722bef8

• [ci skip] (fix): Crate typo, htsget-config instead of htsget-search /cc @mmalenic

  brainstorm

  committed
  26d6eea

  Copy full SHA for 26d6eea

• Add bencher.dev CI/CD

  brainstorm

  committed
  896cd5e

  Copy full SHA for 896cd5e

Commits on May 17, 2023

• Correct GHA syntax for bencher

  brainstorm

  committed
  87f932d

  Copy full SHA for 87f932d

• Adding uses as bencher.dev docs assume, I think they are wrong though?

  brainstorm

  committed
  5f2f7c5

  Copy full SHA for 5f2f7c5

• Move requests benchmarks to htsget-benchmarks crate and **separate** htsget-rs+htsget-refserver benchmark pairing. Aim is for them to run separatedly so that they are easier to paralelise on GHA CI…

  Show description for 7e6a624
  brainstorm

  committed
  7e6a624

  Copy full SHA for 7e6a624

Commits on May 22, 2023

• [ci skip] Experiment with criterion-rs external profiler hooks (https://bheisler.github.io/criterion.rs/book/user_guide/profiling.html#implementing-in-process-profiling-hooks) and extending @koute'…

  Show description for 8b680cd
  brainstorm

  committed
  8b680cd

  Copy full SHA for 8b680cd

Commits on May 29, 2023

• Change benchmark adapter/harness as suggested by @epompeii (thx)

  brainstorm

  committed
  16569f4

  Copy full SHA for 16569f4