Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Django Deployable Swagger #797

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Feat: Django Deployable Swagger #797

merged 4 commits into from
Jan 3, 2025

Conversation

williamputraintan
Copy link
Member

Only in Django Microservice

  • Move swagger local to the deployable endpoint
  • Change swagger path (from /swagger-ui) to /schema/swagger-ui
  • Add NoneAuth for all path prefix with /schema endpoint in API-GW

cc: @raylrui @mmalenic

@williamputraintan williamputraintan added the feature New feature label Jan 3, 2025
@williamputraintan williamputraintan self-assigned this Jan 3, 2025
victorskl
victorskl approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This gonna to be the popular one, Will! One of backlog wish list of all time. Nailed it!

@williamputraintan williamputraintan merged commit 62809ba into main Jan 3, 2025
6 checks passed
@williamputraintan williamputraintan deleted the feat/enable-prod-swagger branch January 3, 2025 03:02
@williamputraintan williamputraintan mentioned this pull request Jan 3, 2025
Closed
@mmalenic mmalenic mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

Assignees

@williamputraintan williamputraintan

Labels
feature New feature platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamputraintan @victorskl