Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

th language not working #1605

Closed
Nabioka opened this issue Mar 6, 2023 · 1 comment · Fixed by #1608
Closed

th language not working #1605

Nabioka opened this issue Mar 6, 2023 · 1 comment · Fixed by #1608
Assignees
@Mavrin
Labels
bug frontend
Milestone
v1.12.0

Comments

@Nabioka
Copy link

Nabioka commented Mar 6, 2023

image
i saw on supported locales it's have thai language but it's not working. and i looking around and i found "frontend/apps/remark42/app/utils/loadLocale.ts" didn't have locale th. maybe that's the problem
Mavrin added a commit to Mavrin/remark that referenced this issue Mar 10, 2023
@Mavrin
umputun#1605 fix loading th locale
09e62fb
@paskal paskal mentioned this issue Mar 10, 2023
Merged
@paskal
Copy link
Collaborator

paskal commented Mar 10, 2023

After the merge of #1608, the master version of the Remark42 Docker image would work without any changes from your side.

umputun pushed a commit that referenced this issue Mar 10, 2023
@Mavrin @umputun
#1605 fix loading th locale
8bd5c0d
@paskal paskal added this to the v1.12.0 milestone Mar 11, 2023
itzomen pushed a commit to traleor/comments that referenced this issue Apr 16, 2023
@Mavrin @itzomen
umputun#1605 fix loading th locale
ef198a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mavrin Mavrin

Labels
bug frontend
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging a pull request may close this issue.

#1605 fix loading th locale Mavrin/remark
3 participants
@paskal @Mavrin @Nabioka