Cleanup images from deleted comments #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
force-pushed
the
paskal/cleanup_images_on_delete
branch
2 times, most recently
from
d03cc8c to
1c2959c
Compare
Pull Request Test Coverage Report for Build 7512255642
💛 - Coveralls |
paskal
force-pushed
the
paskal/cleanup_images_on_delete
branch
from
1c2959c to
fdef8b8
Compare
paskal
force-pushed
the
paskal/cleanup_images_on_delete
branch
from
fdef8b8 to
fd1b906
Compare
umputun
reviewed
Jan 15, 2024
Previously, images were deleted only from comments deleted before EditDuration expiration. After this change, any deletion of the comment deletes images if they are not used elsewhere in comments under the same page.
paskal
force-pushed
the
paskal/cleanup_images_on_delete
branch
from
fd1b906 to
c18ce3f
Compare
umputun
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, images were deleted only from comments deleted before EditDuration expiration. After this change, any deletion of the comment deletes images if they are not used elsewhere in comments under the same page.
FS store got a mutex lock to prevent missing the file in the transition from staging to permanent storage, which otherwise would result in the file being stuck in the permanent storage forever.
Resolves #1698.