refactor!: bump typescript-eslint to v8

.eslintrc.js

@@ -23,7 +23,7 @@ module.exports = {
   },
   rules: {
     '@typescript-eslint/no-non-null-assertion': 'off',
-    '@typescript-eslint/no-var-requires': 'off',
+    '@typescript-eslint/no-require-imports': 'off',
 
     'eslint-plugin/consistent-output': ['error', 'always'],
     'eslint-plugin/meta-property-ordering': 'error',

.github/workflows/ci.yml

@@ -14,12 +14,13 @@ jobs:
           - ubuntu-latest
           # - windows-latest
         node:
-          - 16
           - 18
           - 20
+          - 22
         eslint:
           - '8.56'
           - '8'
+          - '9'
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout Repo

package.json

@@ -7,7 +7,7 @@
   "license": "MIT",
   "packageManager": "[email protected]",
   "engines": {
-    "node": ">=16"
+    "node": ">=18.18"
   },
   "main": "lib/index.js",
   "exports": {
@@ -35,7 +35,7 @@
     "codesandbox:install": "yarn --ignore-engines",
     "lint": "run-p lint:*",
     "lint:docs": "yarn update:eslint-docs --check",
-    "lint:es": "eslint . --cache",
+    "lint:es": "ESLINT_USE_FLAT_CONFIG=false eslint . --cache",
     "lint:tsc": "tsc -p tsconfig.base.json --noEmit",
     "prepare": "patch-package",
     "release": "changeset publish",
@@ -48,7 +48,7 @@
     "eslint": "^8.56.0 || ^9.0.0-0"
   },
   "dependencies": {
-    "@typescript-eslint/utils": "^7.4.0",
+    "@typescript-eslint/utils": "^8.0.0",
     "debug": "^4.3.4",
     "doctrine": "^3.0.0",
     "eslint-import-resolver-node": "^0.3.9",
@@ -82,18 +82,23 @@
     "@total-typescript/ts-reset": "^0.5.1",
     "@types/debug": "^4.1.12",
     "@types/doctrine": "^0.0.9",
-    "@types/eslint": "^8.56.6",
+    "@types/eslint": "^9.6.0",
+    "@types/eslint8.56": "npm:@types/eslint@^8.56.6",
+    "@types/eslint9": "npm:@types/eslint@^9.6.0",
     "@types/is-glob": "^4.0.4",
     "@types/jest": "^29.5.12",
     "@types/json-schema": "^7.0.15",
     "@types/node": "^20.11.30",
-    "@typescript-eslint/eslint-plugin": "^7.4.0",
-    "@typescript-eslint/parser": "^7.4.0",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
+    "@typescript-eslint/rule-tester": "^8.0.0",
     "@unts/patch-package": "^8.0.0",
     "cross-env": "^7.0.3",
     "enhanced-resolve": "^5.16.0",
     "escope": "^4.0.0",
-    "eslint": "^7.2.0 || ^8",
+    "eslint": "^9.8.0",
+    "eslint8.56": "npm:eslint@^8.56.0",
+    "eslint9": "npm:eslint@^9.8.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-doc-generator": "^1.7.0",
     "eslint-import-resolver-typescript": "^3.6.1",

src/rules/dynamic-import-chunkname.ts

@@ -1,7 +1,7 @@
 import vm from 'node:vm'
 
 import type { TSESTree } from '@typescript-eslint/utils'
-import type { RuleFixer } from '@typescript-eslint/utils/dist/ts-eslint'
+import type { RuleFixer } from '@typescript-eslint/utils/ts-eslint'
 
 import { createRule } from '../utils'
 

src/rules/imports-first.ts

@@ -1,13 +1,7 @@
-import { ESLintUtils } from '@typescript-eslint/utils'
-
-import { docsUrl } from '../utils/docs-url'
+import { createRule } from '../utils'
 
 import first from './first'
 
-const createRule = ESLintUtils.RuleCreator(ruleName =>
-  docsUrl(ruleName, '7b25c1cb95ee18acc1531002fd343e1e6031f9ed'),
-)
-
 export = createRule({
   ...first,
   name: 'imports-first',

src/types.ts

@@ -1,6 +1,5 @@
 import type { TSESLint, TSESTree } from '@typescript-eslint/utils'
 import type { ResolveOptions } from 'enhanced-resolve'
-import type { TsResolverOptions } from 'eslint-import-resolver-typescript'
 import type { MinimatchOptions } from 'minimatch'
 import type { KebabCase, LiteralUnion } from 'type-fest'
 
@@ -21,6 +20,12 @@ export type WebpackResolverOptions = {
   argv?: Record<string, unknown>
 }
 
+export type TsResolverOptions = {
+  alwaysTryTypes?: boolean
+  project?: string[] | string
+  extensions?: string[]
+} & Omit<ResolveOptions, 'fileSystem' | 'useSyncFileSystemCalls'>
+
 export type FileExtension = `.${string}`
 
 export type DocStyle = 'jsdoc' | 'tomdoc'
@@ -89,11 +94,10 @@ export type ParseError = {
   column: number
 } & Error
 
-// eslint-disable-next-line @typescript-eslint/ban-types
-export type CustomESTreeNode<Type extends string, T extends object = {}> = Omit<
-  TSESTree.BaseNode,
-  'type'
-> & {
+export type CustomESTreeNode<
+  Type extends string,
+  T extends object = object,
+> = Omit<TSESTree.BaseNode, 'type'> & {
   type: Type
 } & T
 

src/utils/create-rule.ts

@@ -2,4 +2,13 @@ import { ESLintUtils } from '@typescript-eslint/utils'
 
 import { docsUrl } from './docs-url'
 
-export const createRule = ESLintUtils.RuleCreator(docsUrl)
+type ImportXPluginDocs = {
+  /**
+   * The category the rule falls under
+   */
+  category?: string
+
+  recommended?: true
+}
+
+export const createRule = ESLintUtils.RuleCreator<ImportXPluginDocs>(docsUrl)

test/fixtures/deep/cache-2.js

@@ -0,0 +1,2 @@
+import * as c from './c'
+export { c }

test/rules/consistent-type-specifier-style.spec.ts

@@ -1,4 +1,5 @@
-import { TSESLint, TSESTree } from '@typescript-eslint/utils'
+import { RuleTester as TSESLintRuleTester } from '@typescript-eslint/rule-tester'
+import { TSESTree } from '@typescript-eslint/utils'
 
 import { parsers, test } from '../utils'
 
@@ -445,11 +446,12 @@ const FLOW_ONLY = {
 } as const
 
 describe('TypeScript', () => {
-  const ruleTester = new TSESLint.RuleTester({
-    parser: parsers.TS,
-    parserOptions: {
-      ecmaVersion: 6,
-      sourceType: 'module',
+  const ruleTester = new TSESLintRuleTester({
+    languageOptions: {
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module',
+      },
     },
   })
   ruleTester.run('consistent-type-specifier-style', rule, {
@@ -459,11 +461,13 @@ describe('TypeScript', () => {
 })
 
 describe('Babel/Flow', () => {
-  const ruleTester = new TSESLint.RuleTester({
-    parser: parsers.BABEL,
-    parserOptions: {
-      ecmaVersion: 6,
-      sourceType: 'module',
+  const ruleTester = new TSESLintRuleTester({
+    languageOptions: {
+      parser: require(parsers.BABEL),
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module',
+      },
     },
   })
   ruleTester.run('consistent-type-specifier-style', rule, {