fix(#185): add langaugeOptions.parserOptions to flat preset / read sourceType w/ fallback

[SukkaW]

Fixes #185

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[changeset-bot]

🦋 Changeset detected

Latest commit: 1c200bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-import-x	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.12%. Comparing base (e01dce0) to head (ed2126e).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
src/utils/source-type.ts	75.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   96.09%   96.12%   +0.03%     
==========================================
  Files         101      102       +1     
  Lines        4688     4700      +12     
  Branches     1613     1619       +6     
==========================================
+ Hits         4505     4518      +13     
+ Misses        177      174       -3     
- Partials        6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[vladshcherbin]

@SukkaW is it the right fix though?

I'm actually not using any recommended presets with different plugins (e.g. import plugin). They don't give any errors if I don't set languageOptions manually and just use default ones (ecmaVersion, sourceType, parserOptions, etc)

There must be some way the plugin to just use default ones from eslint 🤔

[SukkaW]

@SukkaW is it the right fix though?

I'm actually not using any recommended presets with different plugins (e.g. import plugin). They don't give any errors if I don't set languageOptions manually and just use default ones (ecmaVersion, sourceType, parserOptions, etc)

There must be some way the plugin to just use default ones from eslint 🤔

The PR not only changes the default config presets but also changes how the sourceType is read from the eslint context.

[vladshcherbin]

@SukkaW perfect! Sorry I've somehow missed the second part of update 😅 Will happily switch from import to import-x once the error is resolved. Thank you!

[SukkaW]

@SukkaW perfect! Sorry I've somehow missed the second part of update 😅 Will happily switch from import to import-x once the error is resolved. Thank you!

@vladshcherbin In the meantime, you could try out import-x first, and patch your node_modules with the changes from this PR, to validate if my PR has fixed the issue or not! If the issue still persists, the reproduction would be much appreciated!

[JounQin]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

There is no need to patch to try out this PR, you can just try using CodeSandbox CI's preview artifacts.

[vladshcherbin]

@SukkaW I've tried by patching - the error is still there.

I've also added console.log to current/this version in utils/source-type function to double check and it didn't show anything - I believe it's not even executed in my sample reproduction for some reason. The file is loaded though

Current 4.4.2 reproduction recording

Screen.Recording.2024-11-19.at.13.21.38.mov

reproduction is the same - https://github.com/vladshcherbin/eslint-import

[vladshcherbin]

@SukkaW The rule which gives the error is namespace - sourceType function is not used there. If I turn off this rule - the error is gone ✨

[vladshcherbin]

@SukkaW hey, just wanted to mention I've moved from the original plugin to import-x and use a bunch of rules without seeing this error 🙌