Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add swr for decoupling requests, add search results page #4

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

mentealterne
Copy link
Contributor

Hello Luigi,
sorry for the long PR, I've introduced SWR for decoupling requests, done some refactoring to the UI code and also added a dedicated search page so that search results links can be shareable. Have an happy sunday, it's mid-day so we can start drinking some wine !

@luigibarbato luigibarbato self-requested a review October 12, 2023 20:28
@luigibarbato luigibarbato added the enhancement New feature or request label Oct 12, 2023
@luigibarbato
Copy link
Contributor

SBAM! @mentealterne 💣

Thank you so much for this amazing enhancement, Love it! ❤️

However, I would like to limit the graphic modifications to the components for now. In my opinion, we should focus more on the main structure and functionality since we don't have any strong ideas about restyling the components at the moment. I plan to dedicate an entire chapter to component restyling in the near future. Once again, Alfre, thank you very much 🥇 .

Copy link
Contributor

@luigibarbato luigibarbato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SBAM 🔥

Thank you again, @mentealterne 💣

@luigibarbato luigibarbato merged commit 89a0ead into unconditionalday:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants