feat: tabs with URL navigation #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work! Thanks for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #570
Hey there,
First, thank you for django-unfold, I love it and I'm pretty sure I'm not alone.
Saving the
activeTabstate would benefit the users IMO:Refreshing the page, sharing a link, navigating back and forth would be possible without losing the tab state.
In this PR:
activeTabstate in the URL when clicking tabsactiveTabvariable from the URL during a full reloadThere's one problem with my current approach :
If any hash is detected in the URL, it will become the
activeTabvalue. If the hash doesn't match with any tab href, there will be no tab displayed. Maybe to fix this we should have a naming convention for tabs ? Let me know what you think !Cheers