Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tabs with filters #876

Merged
merged 4 commits into from
Nov 25, 2024
Merged

feat: tabs with filters #876

merged 4 commits into from
Nov 25, 2024

Conversation

lukasvinclav
Copy link
Contributor

No description provided.

@subham1099
Copy link

subham1099 commented Nov 24, 2024

The PR doesn't work when the tabs have different models (without any query params) - it doesn't highlight the tab correctly when filters are applied.

Without filters: screenshot
with filters: screenshot

from the code:

            # In case of tabs, we need to check if the query params are the same
            if tabs and query_params != request_params:
                return False

shouldn't we compare whether the tabs have query params at all? The current implementation won't highlight for tabs with no query params + manually applied filters

@lukasvinclav lukasvinclav merged commit cce7d2e into main Nov 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants