Update macOS build to version 53 #40
Labels
Comments
|
No, I didn't get a similar output running Anyway, I just ran |
Eloston
pushed a commit
that referenced
this issue
Sep 17, 2016
The new Xcode update breaks Homebrew's clang. See #40
|
The Xcode you updated to is 8.0, right? The files in the error messages reside in |
|
I don't, and I'm not sure it should have. The I also have a MacOSX10.6.sdk folder that I installed for something else. |
|
I checked the Chromium instructions, and they don't say anything about Xcode 8. The latest instructions say it supports "7.3+", but nothing about 8.0. The instructions for the version we're building with say "5+", but I think Google's build bots are running 7 already. I also tried Google searching, and I haven't seen anyone post issues with Xcode 8.0 and Chromium. I guess we're entering uncharted territory. |
|
I got 10.11's SDK from here and added to the Xcode folder. Its compiling, lets see what happens. |
|
I'm not understanding how you installed the 10.11 SDK. Do you just drop the directory into that path? Are there some commands you run to set the default SDK? I'm wondering how Chromium knows which SDK to choose... I made that commit earlier hoping that Xcode 8.0's clang compiler included with the 10.12 SDK would be able to build Chromium without a hitch. I believe we've tried to build Chromium with the 10.11 SDK to no avail... |
|
I just downloaded Its compiling just fine so far. hahaha Edit: and just as I was posting this... Edit: I've made a few tests. I renamed the folders to make |
Seems like it. I inspected my build outputs on Debian, and it seems I'm using Could you pull in the commit to use Xcode's clang and try re-building? I want to avoid using Homebrew's LLVM altogether. EDIT: Could you also remove the 10.11 SDK? I would like to see what happens if Chromium tries to build with the 10.12 SDK |
|
Got an error: |
Eloston
pushed a commit
that referenced
this issue
Sep 19, 2016
|
Got another error related to bluetooth. |
|
This error is really interesting, since it's the same file on the same line causing an error, but it's a different error this time :/ In |
|
I did what you said and got an error in Changing this to Edit: this answer is relevant to the SDK stuff. |
|
Relevant information: I tried to build it with homebrew's clang... and got the same error. Doesn't seem to be a problem with Xcode. That being said, I had to switch to the OSX 10.11's SDK, as I was getting these errors with 10.12: What SDK does Google use? |
In here, you got a different error with the same file. It looks like it trips up both LLVM 3.8 and Xcode.
They use their own LLVM version between 3.9 and 4.0 I believe. We might get past these errors if you use Homebrew to install the latest revision or use a specific revision that's new enough. If they made some modifications to LLVM, then we may be out of luck. Also I did more research and switching to |
|
I tried getting a newer version of llvm, turns out Xcode 8.0 has problems building it. haha Now I can't even install llvm3.8 from homebrew. I'll look into downgrading Xcode to 7.3. Edit: I think I found the problem. I'm using Xcode 7.3's command line tools with Xcode 8.0. This is probably messing with the compiling of llvm and chromium. |
Wow, that's frustrating. I wonder why they even bothered to release any Xcode 8.0 components for El Capitan if they're not all ready yet. There's no information on when the tools will be released, so we'd have to wait indefinitely. If you want, you could try downgrading to 7.3 and use Homebrew's clang. Though I'm not sure if this will impact the errors we get with |
|
Well, I've looked around and it seems some of my hardware don't support Sierra (yet). I was going to update just for this, but I guess I'm going to downgrade Xcode to 7.3.1 and try again. Anything I should look for before trying to compile? Edit: downgraded Xcode 7.3.1. At first, I got the same error. We might have to wait a few days before llvm 3.9 gets officially released on homebrew. |
|
Alright sounds good. If you get this to work, let me know where clang lives so I can update the GYP flags and buildlib accordingly. BTW, are you going to install LLVM from homebrew-core, or wait for homebrew-versions to update? I'm wondering if using the one from homebrew-core will remove the use of the version number in the path. |
|
I'll probably install it from homebrew-core. I think using it from there removes the version number from the path. I'm trying to compile with LLVM 3.9 directly downloaded from the official website. Seems to have gotten past the bluetooth error. Before getting it to compile though, I was under the impression buildlib was ignoring my changes in the gyp_flags. Leaving those 3 lines uncommented in build.py should be enough to make my changes in |
|
I'm glad to hear that it got past the bluetooth error. Hopefully this is all that we needed to do... EDIT: I should note that GYP generates ninja configuration files, so ninja should be able to detect the changes and only rebuild the necessary components. |
|
Its working! There was a small error when building the .dmg, though. However, the most interesting part was the message I got when trying to run it: Do you know what is it? |
|
f006c7c. Run I'm not sure what's causing the verification popup. Maybe because it's not installed in |
|
Hmm, I highly doubt so. I've tested version 51 the same way and didn't get this popup. Also, another question. How Chromium defines the locale of search engines? Ask's and Yahoo's searches point to my country's sub-domain. Edit: still getting the error. Its repeating the Edit 2: that message seems to be a bug related to upgrading Chromium in OS X. More info here. |
Eloston
pushed a commit
that referenced
this issue
Sep 22, 2016
Sure. I'll look into implementing this.
Through files in multiple locations; see this patch for an example. |
|
@Eloston Now it builds the damage, but puts the It created a folder called |
I hadn't realized you hated dmgs that much ;) a6253c6. Now LLVM is exactly where Chromium expects it to be. |
|
https://my.mixtape.moe/cioatb.dmg I'll try to build it from scratch tomorrow to check if its working. |
|
Actually I kind of want to resolve #42 before I upload a new version. But thanks for the build anyway. |
|
The current version builds like a charm. Tried it from scratch and everything worked after running the script once. Here is the I think we can close this issue. |
Eloston
added a commit
that referenced
this issue
Oct 25, 2016
The new Xcode update breaks Homebrew's clang. See #40
Eloston
added a commit
that referenced
this issue
Oct 25, 2016
Eloston
added a commit
that referenced
this issue
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spinoff of this comment
@9Morello: Looks like your situation is similar to this. Have you seen something similar to the following in your build output?:
The text was updated successfully, but these errors were encountered: