-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Date::new_from_iso(date_iso, X)
example for each calendar X
#1844
Add Date::new_from_iso(date_iso, X)
example for each calendar X
#1844
Conversation
For Coptic you have to call Coptic::new() for now, it's marked as |
Thanks for the followup @Manishearth ! I went ahead and added the Coptic examples, along with the Buddhist examples. This PR is now in a stable state to review when ready |
Also i just realized Coptic should not be The thing with Japanese is that it has era data that changes occasionally, so we need to load it. Typically the thing to do in tests is to construct it with a |
Adjusted the Coptic example with your changes, thanks @Manishearth ! Separately, I'm still running into issues getting the Japanese example working, so I'll work that into a separate PR/discussion. More specifically, getting
|
Ah, hmm, we've been getting that error a couple times now, it's rust-lang/rust#96223. It just got fixed, I'll try to get it uplifted to beta. Make sure that you're importing icu_provider with the |
Adding a
Date::new_from_iso(date_iso, X)
example at the top level of each calendar.---Below issue has been resolved. Thank you!---
Separately, I am running into issues with the Coptic calendar. Is there a missing permission on access to the type? To demonstrate, the following works:
But the following does not work:
With the error: