CI fix experimentation #2170
Closed
CI fix experimentation #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
All 5 jobs are still failing. The error is new though: |
|
Yep, that's because it selected a stable compiler. |
This reverts commit 3a8a2de.
sffc
reviewed
Jul 12, 2022
| @@ -73,6 +73,8 @@ dependencies = [ "diplomat-gen-c" ] | |||
| install_crate = { rustup_component_name = "rust-src" } | |||
| script_runner = "@duckscript" | |||
| script = ''' | |||
| unset RUSTC | |||
There was a problem hiding this comment.
Nit: If this works, please put a link to an issue that we can track to remove these lines eventually.
|
"Unfortunately" the reverted rustup has been pushed up, so I don't think we can test this way anymore. We can instead test using docker or something. |
|
I think this fix worked though, except for the memory task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.