fix(base): Remove CONFIG_LWIP_FAILNOIFACE
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option `CONFIG_LWIP_FAILNOIFACE` makes sense to enable only for applications that rely on networking. Where networking is optional, this KConfig option should be set to `n` and where no networking is needed, we ideally want to build a Unikernel without networking capabilities and drivers. The `base` image is a generic elfloader image where we are weakening the specialization degree because we need to think a bit more "general purpose": Applications without networking requirements should be able to be run as well. Github-Fixes: #135 Signed-off-by: Simon Kuenzer <[email protected]>
Mihnea0Firoiu
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option
CONFIG_LWIP_FAILNOIFACEmakes sense to enable only for applications that rely on networking. Where networking is optional, this KConfig option should be set tonand where no networking is needed, we ideally want to build a Unikernel without networking capabilities and drivers. Thebaseimage is a generic elfloader image where we are weakening the specialization degree because we need to think a bit more "general purpose": Applications without networking requirements should be able to be run as well.Github-Fixes: #135