-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): Port basic Linux network utilities #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move from library/
to examples/
. See comments for curl/
and apply to all others. Use alpine
or debian
all over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README.md
files should give clear instructions on how to run the images. See the examples of other README.md
files or those that are featured in PR #149 .
Add a top-level README.md
file detailing the contents of the network-tools/
directory.
I would rename the directory to net-tools/
to be more similar to the actual package name (net-tools
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each Kraftfile
should also feature the version
variable, the name
variable and the cmd
variable. Again, similar to all other examples and similar to those in PR #149
4c19315
to
8227f7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use curl/
instead of curl/http3/8.11/
.
Be sure to test all applications with kraft run ...
before hand. For sure traceroute
wouldn't have worked.
Unfortunately my testing enviroment is affected by the HWRNG bug:
and I cannot efficiently test my work without hacky interventions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update your commit message to make it more formal. Use imperative voice. Remove exclamations mark. Recommendation:
"""
Add a handful of Linux network utilities. Note that some of these programs do not work as of writing due to unimplemented kernel features. This is intended for experimental purposes.
"""
6de5baf
to
3b9b2e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]
Add a handful of Linux network utilities. Note that some of these programs do not work as of writing due to unimplemented kernel features. This is intended for experimental purposes. Signed-off-by: Patrick Covaci Ty3r0X <[email protected]>
This PR ports basic GNU/Linux network utilities for use in the Unikraft catalog.