Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): Port basic Linux network utilities #142

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

Ty3r0X
Copy link
Contributor

@Ty3r0X Ty3r0X commented Nov 23, 2024

This PR ports basic GNU/Linux network utilities for use in the Unikraft catalog.

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move from library/ to examples/. See comments for curl/ and apply to all others. Use alpine or debian all over.

library/network-tools/curl/http3/8.11/Dockerfile Outdated Show resolved Hide resolved
library/network-tools/curl/http3/8.11/Dockerfile Outdated Show resolved Hide resolved
library/network-tools/curl/http3/8.11/Dockerfile Outdated Show resolved Hide resolved
library/network-tools/curl/http3/8.11/Dockerfile Outdated Show resolved Hide resolved
library/network-tools/curl/http3/8.11/Kraftfile Outdated Show resolved Hide resolved
@Ty3r0X Ty3r0X requested a review from razvand December 7, 2024 10:59
@razvand razvand self-assigned this Dec 7, 2024
@Ty3r0X Ty3r0X closed this Dec 12, 2024
@Ty3r0X Ty3r0X reopened this Dec 12, 2024
@Ty3r0X Ty3r0X marked this pull request as ready for review December 12, 2024 10:38
@Ty3r0X Ty3r0X changed the title Port basic Linux network utilities feat(examples): Port basic Linux network utilities Dec 12, 2024
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md files should give clear instructions on how to run the images. See the examples of other README.md files or those that are featured in PR #149 .

Add a top-level README.md file detailing the contents of the network-tools/ directory.

I would rename the directory to net-tools/ to be more similar to the actual package name (net-tools).

examples/network-tools/mtr/README.md Outdated Show resolved Hide resolved
examples/network-tools/mtr/README.md Outdated Show resolved Hide resolved
examples/network-tools/netcat/README.md Outdated Show resolved Hide resolved
examples/network-tools/netcat/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each Kraftfile should also feature the version variable, the name variable and the cmd variable. Again, similar to all other examples and similar to those in PR #149

@Ty3r0X Ty3r0X force-pushed the main branch 2 times, most recently from 4c19315 to 8227f7d Compare December 14, 2024 07:53
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use curl/ instead of curl/http3/8.11/.

Be sure to test all applications with kraft run ... before hand. For sure traceroute wouldn't have worked.

examples/net-tools/README.md Outdated Show resolved Hide resolved
examples/net-tools/README.md Outdated Show resolved Hide resolved
examples/net-tools/README.md Outdated Show resolved Hide resolved
examples/net-tools/README.md Outdated Show resolved Hide resolved
examples/net-tools/traceroute/Kraftfile Outdated Show resolved Hide resolved
@Ty3r0X
Copy link
Contributor Author

Ty3r0X commented Dec 14, 2024

Use curl/ instead of curl/http3/8.11/.

Be sure to test all applications with kraft run ... before hand. For sure traceroute wouldn't have worked.

Unfortunately my testing enviroment is affected by the HWRNG bug:

[    0.100076] ERR:  [libukrandom] Could not initialize the HWRNG (-95)

and I cannot efficiently test my work without hacky interventions!

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update your commit message to make it more formal. Use imperative voice. Remove exclamations mark. Recommendation:

"""
Add a handful of Linux network utilities. Note that some of these programs do not work as of writing due to unimplemented kernel features. This is intended for experimental purposes.
"""

examples/net-tools/mtr/Dockerfile Outdated Show resolved Hide resolved
examples/net-tools/curl/Kraftfile Outdated Show resolved Hide resolved
examples/net-tools/dig/Kraftfile Outdated Show resolved Hide resolved
examples/net-tools/host/Kraftfile Outdated Show resolved Hide resolved
examples/net-tools/mtr/Kraftfile Outdated Show resolved Hide resolved
examples/net-tools/mtr/README.md Outdated Show resolved Hide resolved
examples/net-tools/netcat/README.md Outdated Show resolved Hide resolved
examples/net-tools/ping/Kraftfile Outdated Show resolved Hide resolved
examples/net-tools/traceroute/Kraftfile Outdated Show resolved Hide resolved
examples/net-tools/wget/Kraftfile Outdated Show resolved Hide resolved
@razvand razvand added the enhancement New feature or request label Dec 14, 2024
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]

Add a handful of Linux network utilities. Note that some of these programs do not work as of
writing due to unimplemented kernel features. This is intended for experimental purposes.

Signed-off-by: Patrick Covaci Ty3r0X <[email protected]>
@razvand razvand merged commit f19453e into unikraft:main Dec 14, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants