Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(archive): Migrate errors to constants #1601

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

frs513
Copy link

@frs513 frs513 commented Apr 25, 2024

Unwrapped errors: ErrTarFileNoDest and ErrTarFileWriteDir

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Unwrapped errors: ErrTarFileNoDest and ErrTarFileWriteDir
@nderjung
Copy link
Member

Hi @frs513! Thanks for this addition.

Could you please add your sign off to the commit message?

Please also check the static checks which have failed: https://github.com/unikraft/kraftkit/actions/runs/8840310392/job/24326614178?pr=1601

Tip: You can run make fmt and make cicheck locally before submitting a PR to run these tests.

@nderjung nderjung marked this pull request as draft May 24, 2024 10:53
@craciunoiuc
Copy link
Member

Hey @frs513

Are you still working on this?

@frs513
Copy link
Author

frs513 commented Jun 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants