Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kconfig): Introduce Walk and minor fixes #1855

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

nderjung
Copy link
Member

The newly exposed Walk method allows for iterating across all
elements of the parsed KConfig tree. To make this change possible,
a number of changes were necessary:

  1. All menu known menu types are required to be expressed and this
    is expressed as new consts;
  2. The "Source" of the file is provided for all menu items which
    aids in identify the placement of the menu given its file
    context.

Signed-off-by: Alexander Jung [email protected]

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

The newly exposed `Walk` method allows for iterating across all
elements of the parsed KConfig tree.  To make this change possible,
a number of changes were necessary:

1. All menu known menu types are required to be expressed and this
   is expressed as new `const`s;
2. The "`Source`" of the file is provided for all menu items which
   aids in identify the placement of the menu given its file
   context.

Signed-off-by: Alexander Jung <[email protected]>
@nderjung nderjung changed the title feat(kconfig): Introduce Walk feat(kconfig): Introduce Walk and minor fixes Aug 21, 2024
Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu [email protected]
Approved-by: Cezar Craciunoiu [email protected]

@craciunoiuc craciunoiuc merged commit 0208c45 into unikraft:staging Aug 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants