Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): Check if volume is populated also #1962

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

craciunoiuc
Copy link
Member

Only checking the error does not guarantee that the volume actually exists.

GitHub-Fixes: #1958

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Only checking the error does not guarantee that the
volume actually exists.

GitHub-Fixes: unikraft#1958
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc craciunoiuc requested a review from nderjung November 19, 2024 12:18
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nderjung nderjung merged commit 0d5eff7 into unikraft:staging Nov 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume configuration in Kraftfile causes a kraftkit crash / invalid memory address / nil pointer dereference
2 participants