fix(qemu): Allow listing over instances which cannot be queried over QMP #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit amortizes the errors from connection sequences via QMP into well-defined errors. These errors can then be cross-validated in the listing method which would otherwise fast-fail. By omitting any issues related via QMP, we are able to properly return a full list of machines, regardless of whether they have a QMP socket. Signed-off-by: Alexander Jung <[email protected]>
nderjung
force-pushed
the
nderjung/fix/machine/qemu/iterate-over-dead-qmp-instances
branch
from
a0ed982 to
1a49ec4
Compare
craciunoiuc
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu [email protected]
Approved-by: Cezar Craciunoiu [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
This PR amortizes the errors from connection sequences via QMP into well-defined errors. These errors can then be cross-validated in the listing method which would otherwise fast-fail. By omitting any issues related via QMP, we are able to properly return a full list of machines, regardless of whether they have a QMP socket.