Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move runtime directory to user scope #731

Merged

Conversation

craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Out of all attempted methods at fixing the problem, it seems that the
least convoluted one resumes itself to just moving the runtime directory
to a place with enough permissions.

The first commit moves the runtime directory from /var/kraftkit to
$HOME/.local/kraftkit where the use has permission without sudo or
other tricks.

The second one removes a partial attempt at fixing the problem.

Closes: #585
Closes: #615
Closes: #716

Out of all attempted methods at fixing the problem, it seems that the
least convoluted one resumes itself to just moving the runtime directory
to a place with enough permissions.

This commit moves the runtime directory from `/var/kraftkit` to
`$HOME/.local/kraftkit` where the use has permission without sudo or
other tricks.

Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc craciunoiuc added area/cmd Issue or PR related to all CLI programs kind/fix This PR fixes an issue or bug area/config Issue or PR is related to the config package kind/refactor area/oci Issue or PR is related to OCI package management area/machine Issue or PR is related to KraftKit's machine instance subsystem labels Aug 21, 2023
@craciunoiuc craciunoiuc requested a review from nderjung August 21, 2023 09:45
@jake-ciolek jake-ciolek self-requested a review August 21, 2023 10:03
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/move-runtime-directory branch from 88d9ac4 to 9fda1a7 Compare August 21, 2023 14:10
@craciunoiuc craciunoiuc assigned jake-ciolek and unassigned nderjung Aug 21, 2023
@craciunoiuc craciunoiuc requested review from jake-ciolek and removed request for nderjung August 21, 2023 14:11
@jake-ciolek jake-ciolek merged commit 55392fd into unikraft:staging Aug 21, 2023
@craciunoiuc craciunoiuc deleted the craciunoiuc/move-runtime-directory branch October 17, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cmd Issue or PR related to all CLI programs area/config Issue or PR is related to the config package area/machine Issue or PR is related to KraftKit's machine instance subsystem area/oci Issue or PR is related to OCI package management kind/fix This PR fixes an issue or bug kind/refactor
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

Create kraftkit group and chown runtime dir
3 participants