Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI job to test the validity of the light client binary. #34

Closed
KaiserKarel opened this issue May 18, 2023 · 1 comment
Closed

Add a CI job to test the validity of the light client binary. #34

KaiserKarel opened this issue May 18, 2023 · 1 comment
Assignees
@aeryz
Labels
A-ci Area: Our CI C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@KaiserKarel
Copy link
Contributor

The wasm light client can be invalid because of several factors such as having floating point operations. The validity of the client should be tested in the CI. An easy and legit way to do this is to specify the binary in the genesis and see if it failed. Or we can also just write an integration test in Go code.
@KaiserKarel KaiserKarel added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-ci Area: Our CI labels May 18, 2023
@aeryz
Copy link
Contributor

aeryz commented May 30, 2023

This is implemented in #92.

@aeryz aeryz closed this as completed May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeryz aeryz

Labels
A-ci Area: Our CI C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeryz @KaiserKarel