fix: ensure no invalid opcodes in wasm light client binary #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benluelo
force-pushed
the
91-wasm-light-client-contains-invalid-opcodes
branch
from
10182ee to
bd9fc0d
Compare
cor
previously approved these changes
May 24, 2023
benluelo
force-pushed
the
91-wasm-light-client-contains-invalid-opcodes
branch
from
bd9fc0d to
524c0b8
Compare
hussein-aitlahcen
previously approved these changes
May 24, 2023
aeryz
reviewed
May 25, 2023
benluelo
force-pushed
the
91-wasm-light-client-contains-invalid-opcodes
branch
from
524c0b8 to
c09430f
Compare
aeryz
approved these changes
May 26, 2023
cor
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added a check to ensure that sign-ext opcodes don't find their way back into the binary.
this also provides a significant improvement to the size of the binary, from 2.8M to 1.1M (758K to 322K gzipped).
closes #91