Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in README about clang error while installing #255

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,13 @@ we also provide the following alternate lighter install options:
* Install core + neural networks (PyTorch): `pip install 'u8darts[torch]'`
* Install core + Facebook Prophet: `pip install 'u8darts[fbprophet]'`
* Install core + AutoARIMA: `pip install 'u8darts[pmdarima]'`


Note: In case you run into errors with `clang` (the C compiler) set the variables `CC` and `CXX` as follows:
```bash
export CC=/usr/bin/clang
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these commands depend on the exact setup. Perhaps worth adding a note saying that this is only an example which should (most of the time) work out of the box on MacOS for example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it's actually an issue with the darts [couldn't reproduce on my Mac], as it seems more connected to compiling one of the dependencies and general setup - I think we should either start a new page (Troubleshooting?) or let the users get their setups right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried to reproduce the same in my personal Mac (OS Catalina) and the installation went smoothly (no need to setup env variables). I only encountered this issue with a new MacBook (OS Catalina). I will try to investigate if others are having the same problem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: Mos (Mostafa Ajallooeian) tested the Darts installation with his new MacBook (OS Catalina), and he didn't experience any issue. I also tested the installation on another MacBook (OS Big Sur) and the installation was successful. I propose to close the PR as the issue seems to be specific to my setup

export CXX=/usr/bin/clang++
```

### Running the examples only, without installing:

If the conda setup is causing too many problems, we also provide a Docker image with everything set up for you and ready-to-use python notebooks with demo examples.
Expand Down