-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win32: Add version resource and manifest #2360
Conversation
This manifest enables UTF-8 code page. https://docs.microsoft.com/en-us/windows/uwp/design/globalizing/use-utf8-code-page
Add them with win32 makefiles.
Add compatibility element. This element is included by default when compiled with MinGW-w64.
Also remove outdated comments.
Codecov Report
@@ Coverage Diff @@
## master #2360 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 176 176
Lines 35717 35717
=======================================
Hits 30808 30808
Misses 4909 4909 Continue to review full report at Codecov.
|
I don't have enough knowledges to review this. Feel free to merge this when you think you are o.k. |
Do you have any comments about the commit messages, or about usage of autotools and makefiles? |
I have only one very minor suggestion. |
I see. Instead of improving our build-sys for synchronizing them, verifying the consistency of them at on travis may be easy. I like the technique you introduced for converting man to docs/man. Implementing verifier is much easier, but effective. |
Set to empty at the head of the file, then use `+=`.
We need to verify the following points: Line 10 in 105f514
Lines 55 to 58 in 105f514
Line 20 in 105f514
ctags/win32/ctags.exe.manifest Line 3 in 105f514
Lines 61 to 62 in 105f514
Line 79 in 105f514
Line 84 in 105f514
Note that Windows uses X.Y.Z.W (or X,Y,Z,W) style, not X.Y.Z. Maybe we should set to X.Y.Z.0. |
This adds version resource and application manifest to the win32 executable file.
win32/ctags.rc
andwin32/resource.h
are created by VS2013 and edited manually.The application manifest should fix the issue #1837 on Windows 10 version 1903 or later.
See: https://docs.microsoft.com/en-us/windows/uwp/design/globalizing/use-utf8-code-page
This is a relatively new feature in Windows and it might not be matured enough, but at least I confirmed that ctags.exe can handle Unicode file names on Windows 10 1909.
NOTE: the version number needs to be updated manually.
We have version numbers in several files:
configure.ac
,docs/conf.py
,main/ctags.h
,win32/ctags.exe.manifest
andwin32/ctags.rc
. (The last two files are added in this PR.)We need to update all of them, when we release a new version.