springboard apps to be deployable #78
Conversation
|
@Rizziepit review please |
| @@ -0,0 +1,93 @@ | |||
| [app:springboardfrontend] | |||
| use = egg:springboard-{{ app_type }} | |||
There was a problem hiding this comment.
This should use _ instead of - like https://github.com/universalcore/unicore-mc/pull/78/files#diff-5e7b9f95bfe899b8e57feed82a33ca49R38
| pyramid.default_locale_name = {{default_language}} | ||
|
|
||
| featured_languages = | ||
| {{default_language}} |
There was a problem hiding this comment.
By default springboard will show the current language + featured languages. So when the default language is the current language, with this value, only the default language will be displayed in the header. Perhaps we need to put default_language plus one or two other available languages here.
There was a problem hiding this comment.
@Rizziepit I was meant to remove this. We currently don't specify featured languages anymore in Mission Control so this should be blank. The fallback should be current language + 2 other
There was a problem hiding this comment.
Ok cool. Can you open an issue on springboard so that we implement the fallback?
|
+1 when tests are passing again |
…d-apps-to-be-deployable springboard apps to be deployable
No description provided.