Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fancy): fallback whenIntl is unavailable #326

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

gcaaa31928
Copy link
Contributor

Added a fallback to handle cases where Intl isn’t available. This keeps things running smoothly even in environments without Intl support. For more details, check out the Node.js docs on detecting internationalization support.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 20.79%. Comparing base (24c98ce) to head (7fda533).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
src/reporters/fancy.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #326       +/-   ##
===========================================
- Coverage   61.08%   20.79%   -40.30%     
===========================================
  Files          13       43       +30     
  Lines        1380     2318      +938     
  Branches       58       88       +30     
===========================================
- Hits          843      482      -361     
- Misses        537     1808     +1271     
- Partials        0       28       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 changed the title fix: add fallback when intl is unavailable fix(fancy): fallback whenIntl is unavailable Dec 23, 2024
@pi0 pi0 merged commit d9b58df into unjs:main Dec 23, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants