-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helper to parse multipart/form-data
#280
Conversation
Used library seems a fork and no esm exports. It would be nice if we can inline and cleanup implementation (author shall be be preserved in same file) |
Can we name it |
Shall we just open a PR to add esm exports upstream? |
I prefer inlining for easier future enhancenments. It is same for other utils. |
It just seems less maintainable, that's all, as there's already someone actively maintaining it. But if you wish. |
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 74.36% 75.84% +1.48%
==========================================
Files 20 21 +1
Lines 1541 1681 +140
Branches 240 273 +33
==========================================
+ Hits 1146 1275 +129
- Misses 395 406 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Reverted the utility name back to |
π Linked issue
resolves #43
β Type of change
π Description
This adds a utility to read
multipart/form-data
:readMultipartFormData
. It's a separate utility so it doesn't add to the bundle size if not used, as it usesparse-multipart-data
to handle the parsing.π Checklist