-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(proxy): separate multiple cookie headers #319
Conversation
Codecov Report
@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 70.85% 71.92% +1.07%
==========================================
Files 22 23 +1
Lines 1983 2066 +83
Branches 289 303 +14
==========================================
+ Hits 1405 1486 +81
- Misses 578 580 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ❤️
I have problem with this PR, Second cookie from header not applied and found next in the web Origin servers SHOULD NOT fold multiple Set-Cookie header fields into a single header field. The usual mechanism for folding HTTP headers fields (i.e., as defined in [RFC2616]) might change the semantics of the Set-Cookie header field because the %x2C (",") character is used by Set-Cookie in a way that conflicts with such folding. What you think @pi0 ? |
re: #318 proxying multiple cookies and split by comma