Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add semi #710

Merged
merged 2 commits into from
Apr 17, 2024
Merged

docs: add semi #710

merged 2 commits into from
Apr 17, 2024

Conversation

etroynov
Copy link
Contributor

πŸ”— Linked issue

  • no issue;

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@etroynov
Copy link
Contributor Author

@pi0 @Barbapapazes can you check it? Thx.

@Barbapapazes Barbapapazes changed the title docs: fix typo on Router page docs: fix typo on router page Mar 18, 2024
@Barbapapazes Barbapapazes requested a review from pi0 March 18, 2024 12:21
@Barbapapazes Barbapapazes added the documentation Improvements or additions to documentation label Mar 18, 2024
@Barbapapazes
Copy link
Member

@pi0 @Barbapapazes can you check it? Thx.

Hey, thanks for the fix but please, do not ping us until something is critical!

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 77.79%. Comparing base (a58d7c9) to head (18eb901).
Report is 49 commits behind head on main.

❗ Current head 18eb901 differs from pull request most recent head 13d2a2d. Consider uploading reports for the commit 13d2a2d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   77.83%   77.79%   -0.05%     
==========================================
  Files          47       55       +8     
  Lines        4286     5196     +910     
  Branches      611      683      +72     
==========================================
+ Hits         3336     4042     +706     
- Misses        933     1134     +201     
- Partials       17       20       +3     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title docs: fix typo on router page docs: add semi Apr 17, 2024
@pi0 pi0 merged commit 2c4ccde into unjs:main Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants