Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(session): remove unnecessary async for clear #729

Merged
merged 4 commits into from
Apr 17, 2024
Merged

refactor(session): remove unnecessary async for clear #729

merged 4 commits into from
Apr 17, 2024

Conversation

remonke
Copy link
Contributor

@remonke remonke commented Apr 8, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Removes unnecessary async from the clearSession() function. setCookie is a synchronous function, so the function doesn't have to be asynchronous.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix(session): remove unnecessary async refactor(session): remove unnecessary async Apr 17, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. The clearSession / clear utils were intentionally marked as async for future compatibility we might need them async. I've made a refactor to keep it more readable.

@pi0 pi0 changed the title refactor(session): remove unnecessary async refactor(session): remove unnecessary async for clear Apr 17, 2024
@pi0 pi0 merged commit 9bd4aef into unjs:main Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants