-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node): make sure onBeforeResponse
and onAfterResponse
are called with error code
#756
Conversation
/cc @pi0 can you review my PR? π This fix is very necessary for my app. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 77.83% 79.67% +1.84%
==========================================
Files 47 54 +7
Lines 4286 5363 +1077
Branches 611 692 +81
==========================================
+ Hits 3336 4273 +937
- Misses 933 1071 +138
- Partials 17 19 +2 β View full report in Codecov by Sentry. |
onBeforeResponse
and onAfterResponse
are called with error code
Thanks for PR and nice tests @imslepov β€οΈ I have updated the implementation to minimize the required changes. Expected tests pass still but we call hooks only before sending response body. In future, It should be cleaner but requires more additional core refactors later. |
π Linked issue
Closes #754
β Type of change
π Checklist