Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow chaining use statements #9

Merged
merged 1 commit into from
Nov 22, 2020
Merged

feat: allow chaining use statements #9

merged 1 commit into from
Nov 22, 2020

Conversation

danielroe
Copy link
Member

closes #5

@danielroe
Copy link
Member Author

now I feel there must have been more to your thinking - so happy to close this if you had something more elaborate in mind...

pi0
pi0 approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it is perfect (if you mind directly updating docs in main would be awesome)

I created issue as a task also reminder to support it for sort method if added

@pi0 pi0 merged commit e30ea79 into main Nov 22, 2020
@pi0 pi0 deleted the allow-chaining branch November 22, 2020 09:28
danielroe added a commit that referenced this pull request Nov 22, 2020
@danielroe
docs: add example of chaining .use()
d05afe4 
* add corresponding test
* update types

follow-up to #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow chaining app.*
2 participants
@danielroe @pi0