Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils/filename): handle files beginning with a period or without ext #185

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

cjpearson
Copy link
Contributor

@cjpearson cjpearson commented Sep 27, 2024

(#184)

This change resolves the issue reported with files containing no extension. It also adds tests for filenames such as .gitignore or .env which begin with a period.

src/utils.ts Show resolved Hide resolved
@cjpearson cjpearson force-pushed the issue-184 branch 2 times, most recently from 50fec47 to a576974 Compare September 27, 2024 19:16
@pi0 pi0 changed the title fix(filename): handle files beginning with a period or without extensions fix(utils/filename): handle files beginning with a period or without ext Dec 30, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (bdab761) to head (8cf6c12).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   99.45%   99.30%   -0.15%     
==========================================
  Files           4        4              
  Lines         364      289      -75     
  Branches      114      119       +5     
==========================================
- Hits          362      287      -75     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 merged commit e68f5cd into unjs:main Dec 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants