Generic Tree Addition #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 14, 2012 14:31
Remove unnecessary and unavailable project kyodai-parser from the classpath.
The LookupIdStore and IdStore classes can be used to associate generic items with integer IDs. These integer IDs can be used as the IDs in the tree.
The generic package contains Contains an interface and implementation for a generic tree. A generic tree mirrors a tree, but allows for generic values at each node rather than simply integers. Generic trees can be interacted with using the values contained in the tree, the integer IDs for these values, or a combination of both. This commit includes implementations and comments.
Fixed JUnit tests to use import methods from org.junit.Assert rather than the built in assert command
ghost
assigned 
|
Hi Josh Sorry for late replay, and thank you for your pull request. I'm happy that my small library is used for other projects! I think generic tree interface is useful for other projects. I will check you pull request and merge it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Yuya,
I added the capability to create trees of generic items on top of your tree-edit distance framework. I used this in another project to make it easier for me to apply your framework to an tree node class that already existed. This addition may be useful for you or others who find your project, so I wanted to give you the opportunity to pull it into your project. Nothing was changed in your project, the generic capabilities were simply added on top of it.
I will be working with tree-edit-distance a bit further and may end up needing to add things like constrained edit distance or a mapping between more then two trees. These additions could potentially change things in your original code base. It's up to you if you would like me to push this current change and any further changes over to you or simply maintain them in my fork of the project.
Thanks a bunch for putting your tree-edit-distance project on GitHub. I am working on a project to compare Java Abstract Syntax Trees and it has proved incredibly useful so far.
Josh