Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update samples for MVUX generated class #818

Merged
merged 2 commits into from
Sep 26, 2024
Merged

chore: update samples for MVUX generated class #818

merged 2 commits into from
Sep 26, 2024

Conversation

Kunal22shah
Copy link
Contributor

@Kunal22shah Kunal22shah self-assigned this Aug 27, 2024
eriklimakc
eriklimakc approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@eriklimakc eriklimakc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to update the MVVM samples (Counter and SimpleCalc) Sdk to have them all using the same version?

cc @agneszitte @Kunal22shah @jeromelaban

@agneszitte agneszitte mentioned this pull request Aug 27, 2024
Merged
3 tasks
@agneszitte agneszitte marked this pull request as draft August 28, 2024 23:31
@Kunal22shah Kunal22shah force-pushed the dev/ks/samples-update-mvux-bindableProxy branch from 5453ade to 0a4fb62 Compare September 26, 2024 16:14
@Kunal22shah Kunal22shah marked this pull request as ready for review September 26, 2024 16:16
@agneszitte agneszitte disabled auto-merge September 26, 2024 17:10
@agneszitte agneszitte merged commit e470a0a into master Sep 26, 2024
11 checks passed
@agneszitte agneszitte deleted the dev/ks/samples-update-mvux-bindableProxy branch September 26, 2024 18:48
@agneszitte agneszitte mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte approved these changes

@eriklimakc eriklimakc eriklimakc approved these changes

@ajpinedam ajpinedam Awaiting requested review from ajpinedam

Assignees

@Kunal22shah Kunal22shah

Labels
do-not-merge/in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kunal22shah @agneszitte @eriklimakc