-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay TextBox
improvements
#10935
Overlay TextBox
improvements
#10935
Conversation
@MartinZikmund does it fixes #10259 ? |
Definitely 👍 |
src/Uno.UI.Runtime.Skia.Gtk/UI/Xaml/Controls/MultilineTextBoxView.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.Gtk/UI/Xaml/Controls/SinglelineTextBoxView.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.Wpf/Extensions/UI/Xaml/Controls/PasswordTextBoxView.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.Wpf/Extensions/UI/Xaml/Controls/PasswordTextBoxView.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.Wpf/Extensions/UI/Xaml/Controls/WpfTextBoxView.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/OverlayTextBoxView/OverlayTextBoxViewExtension.skia.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/OverlayTextBoxView/OverlayTextBoxViewExtension.skia.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/OverlayTextBoxView/OverlayTextBoxViewExtension.skia.cs
Show resolved
Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/OverlayTextBoxView/OverlayTextBoxViewExtension.skia.cs
Outdated
Show resolved
Hide resolved
be445d0
to
f2d14dd
Compare
The build 66345 found UI Test snapshots differences: Details
|
The build 66423 found UI Test snapshots differences: Details
|
The build 66565 found UI Test snapshots differences: Details
|
b36f287
to
7b088fe
Compare
The build 66646 found UI Test snapshots differences: Details
|
The build 66637 found UI Test snapshots differences: Details
|
2617efd
to
54d2cc7
Compare
src/Uno.UI.Runtime.Skia.Wpf/Extensions/UI/Xaml/Controls/WpfTextBoxView.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/OverlayTextBoxView/OverlayTextBoxViewExtension.skia.cs
Outdated
Show resolved
Hide resolved
The build 68571 found UI Test snapshots differences: Details
|
980a7dd
to
61c4c8c
Compare
The build 68741 found UI Test snapshots differences: Details
|
# Conflicts: # src/Uno.UI/UI/Xaml/Controls/TextBox/TextBoxView.skia.cs
# Conflicts: # src/Uno.UI.Runtime.Skia.Wpf/Extensions/UI/Xaml/Controls/TextBoxViewExtension.cs
1b02074
to
b02c501
Compare
The build 71529 found UI Test snapshots differences: Details
|
GitHub Issue (If applicable): closes #10259, closes #6289
TODOs
IsPassword
to clarify distinction between "password reveal" and "PasswordBox
"Remaining issues moved to #11591
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):