Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump SkiaSharp to 2.88.7 #15567

Merged
merged 34 commits into from
Mar 6, 2024
Merged

chore: Bump SkiaSharp to 2.88.7 #15567

merged 34 commits into from
Mar 6, 2024

Conversation

jeromelaban
Copy link
Member

The SkiaSharp update is possible since 5.1, as Uno for net7-ios is depending on Microsoft 16.4 after a forced workloads update, and SkiaSharp for net7-ios is depending on Microsoft 16.2.

We're still dependent on dotnet/sdk#30103 for future updates, if the workloads end up changing on SkiaSharp's end.

@github-actions github-actions bot added area/solution-templates Categorizes an issue or PR as relevant to the solution template area/build Categorizes an issue or PR as relevant to build infrastructure area/automation Categorizes an issue or PR as relevant to project automation kind/documentation labels Feb 21, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

@jeromelaban jeromelaban mentioned this pull request Feb 21, 2024
Merged
jeromelaban added a commit to unoplatform/uno.templates that referenced this pull request Feb 21, 2024
@jeromelaban
chore: Revert "Adding SkiaSharp packages"
b23beb0 
Using unoplatform/uno#15567 instead.
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

2 similar comments
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

@jeromelaban jeromelaban force-pushed the dev/jela/skia-update branch from f0a51a6 to 249369e Compare March 4, 2024 15:18
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

jeromelaban and others added 21 commits March 6, 2024 08:08
@jeromelaban
chore: Adjust fb-idb install
ed16de9
@jeromelaban
chore: Copy dump nunit files to log directory
684bd30
@jeromelaban
chore: Adjust dump copy
14892be
@jeromelaban
chore: Scan temp directory for dump files
125096e
@jeromelaban
chore: recursive copy dump files
94580e9
@jeromelaban
chore: Use x64 for test runner
b9a11b8
@jeromelaban
chore: Don't pre-install the app
02703b7
@jeromelaban
chore: install using idb
38dd600
@jeromelaban
chore: Adjust IDB location
d55aa3b
@jeromelaban
chore: Adjust IDB companion install
b4e73d4
@jeromelaban
chore: Restore fb
c0744cf
@jeromelaban
chore: use net8 for running iOS tests
ef534ee
@jeromelaban
chore: Adjust iOS test base framework
301b532
@jeromelaban
chore: Force target framework for ui tests
b54478e
@jeromelaban
chore: Adjust test base TF
39fccee
@jeromelaban
chore: Don't warn on regex for tests
3c8ebc9
@jeromelaban
chore: Rollback to macos-12 for Xamarin.UITest compatibility
3505a03
@jeromelaban
chore: restore net7 for tests
813cca9
@jeromelaban
chore: Disable android rerun, reduce android timeout
e7ef299 
Disabled rerun to rely on external auto retry
@jeromelaban
chore: restore automatic rerun
727dbf7
@jeromelaban
chore: Adjust macos assets
43d3458
@jeromelaban jeromelaban force-pushed the dev/jela/skia-update branch from bbe9e97 to 43d3458 Compare March 6, 2024 13:11
@jeromelaban
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15567/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15567/index.html

@jeromelaban jeromelaban enabled auto-merge March 6, 2024 15:12
@jeromelaban jeromelaban disabled auto-merge March 6, 2024 18:28
@jeromelaban jeromelaban merged commit d6b0ae9 into master Mar 6, 2024
99 of 101 checks passed
@jeromelaban jeromelaban deleted the dev/jela/skia-update branch March 6, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@dansiegel dansiegel dansiegel approved these changes

@agneszitte agneszitte agneszitte approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/build Categorizes an issue or PR as relevant to build infrastructure area/solution-templates Categorizes an issue or PR as relevant to the solution template kind/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromelaban @unodevops @spouliot @dansiegel @agneszitte