fix(itemsRepeater): Fix an issue where IR might re-position first items if items below are significantly higher #15946

dr1rrb · 2024-03-19T21:28:56Z

Bugfix

Fix an issue where IR might re-position first items if items below are significantly higher

What is the current behavior?

When an item is significantly higher than previous ones, when recycling old items the the average size changes causing items being re-positioned.

What is the new behavior?

We make sure to never consider a negative original point.

PR Checklist

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

…ms if items below are significantly higher

src/SamplesApp/UITests.Shared/ItemExclusions.props

src/Uno.UI/Microsoft/UI/Xaml/Controls/Repeater/StackLayout.cs

unodevops · 2024-03-19T21:51:19Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-20T13:50:31Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-20T18:04:25Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-20T19:43:25Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-20T22:03:29Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-20T23:00:02Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15946/index.html

…ring synschronously

unodevops · 2024-03-21T17:01:55Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-21T18:04:50Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15946/index.html

dr1rrb · 2024-03-22T13:22:17Z

/azp run

azure-pipelines · 2024-03-22T13:22:39Z

Azure Pipelines successfully started running 2 pipeline(s).

unodevops · 2024-03-22T13:43:53Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-22T13:44:13Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-25T14:44:39Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-25T14:47:17Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-25T22:37:06Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-25T22:39:17Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-26T14:43:40Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15946/index.html

unodevops · 2024-03-26T14:52:57Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15946/index.html

nventive-devops · 2024-03-26T17:16:35Z

The build 118013 found UI Test snapshots differences: android-28-net7: 16, android-28-net7-Snap: 51, ios: 220, ios-Snap: 1053, skia-gtk-screenshots: 35, skia-linux-screenshots: 33, skia-windows-screenshots: 16, wasm: 82, wasm-automated-net7.0-UWP-Default-automated: 32, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0

Details

android-28-net7: 16 changed over 823
🚨🚨 Comparison Details (first 20) 🚨🚨
- DoesNotInterfereWithHorizontalDrag_UITests_Microsoft_UI_Xaml_Controls_RefreshContainerTests_RefreshContainerHorizontalScroll
- When_InListView_after_scroll
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- When_InScrollViewer_after_scroll
- WebView_NavigateToAnchor_Initial
- WebView_NavigateToLongString_AfterSuccess
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- Button_OverlappedButtons_UITests_Shared_Windows_UI_Xaml_Controls_Button_Overlapped_Buttons
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
android-28-net7-Snap: 51 changed over 1063
🚨🚨 Comparison Details (first 20) 🚨🚨
- ItemsRepeater_UITests_Windows_UI_Xaml_Controls_Repeater_ItemsRepeater_Nested_UITests_Windows_UI_Xaml_Controls_Repeater_ItemsRepeater_Nested
- ItemsRepeater_UITests_Windows_UI_Xaml_Controls_Repeater_StackLayout_Simple_UITests_Windows_UI_Xaml_Controls_Repeater_StackLayout_Simple
- ItemsRepeater_UITests_Windows_UI_Xaml_Controls_Repeater_UniformGridLayout_Simple_UITests_Windows_UI_Xaml_Controls_Repeater_UniformGridLayout_Simple
- Shapes_UITests_Windows_UI_Xaml_Shapes_LineStretchModes_UITests_Windows_UI_Xaml_Shapes_LineStretchModes
- Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
- Shapes_UITests_Windows_UI_Xaml_Shapes_EllipseAlignment2542_2547_UITests_Windows_UI_Xaml_Shapes_EllipseAlignment2542_2547
- Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
- Shapes_UITests_Windows_UI_Xaml_Shapes_Path_Custom_UITests_Windows_UI_Xaml_Shapes_Path_Custom
- TextBlock_TextBlock_LineHeight_TextTrimming_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_TextTrimming
- TextBlock_TextBlock_Nested_Measure_With_Outer_Alignments_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Nested_Measure_With_Outer_Alignments
- TextBlock_TextBlock_Padding_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Padding
- MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage
- Scrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage
- TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
- TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
- Thumb_UITests_Windows_UI_Xaml_Controls_ThumbTests_Thumb_DragEvents_UITests_Windows_UI_Xaml_Controls_ThumbTests_Thumb_DragEvents
- ToggleSwitch_Native_ToggleSwitch_IsOn_SamplesApp_Windows_UI_Xaml_Controls_ToggleSwitchControl_Native_ToggleSwitch_IsOn
- ToggleSwitch_ToggleSwitch_Custom_SamplesApp_Windows_UI_Xaml_Controls_ToggleSwitchControl_ToggleSwitch_Custom
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- ItemsRepeater_UITests_Windows_UI_Xaml_Controls_Repeater_ItemsRepeater_Basics_UITests_Windows_UI_Xaml_Controls_Repeater_ItemsRepeater_Basics
ios: 220 changed over 265
🚨🚨 Comparison Details (first 20) 🚨🚨
- BitmapSource_PixelSize_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_ImageSource_PixelSize
- Check_CornerRadius_Border_No_CornerRadius
- Image_Invalid_image_invalid_before_hide
- ItemsControl_ReplaceItem_UITests_Windows_UI_Xaml_Controls_ItemsControl_ItemsControl_ReplaceItem
- ListView_ChangingText_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text
- ListView_ExpandableItemLarge_ExpandHeader_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ObservableCollection_Creation_Count_Added
- PasswordBox_AutoGrow_Horizontally_Test_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Simple
- Screenshots_Image_Stretch_Alignment_Bigger_Mode-0
- Screenshots_Image_Stretch_Alignment_Bigger_Mode-1
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_FontWeight_Changed_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_FontWeight_Dynamic
- ComboBoxTests_Stretch_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Stretch
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ExpandableItem_ExpandSingleItem_Collapsed_State
- ListView_SelectedItem_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_SelectedItem
- ListView_Selection_Events_Ordering_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Events
- Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-1
- Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-2
- TextBox_NaturalSize_When_Empty_Is_Right_Width_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxes_TextBox_NaturalSize
ios-Snap: 1053 changed over 1054
🚨🚨 Comparison Details (first 20) 🚨🚨
- AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion
- Border_BorderBottomwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderBottomwithmargins
- Border_Border_Simple_No_Background_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background
- Border_Simple_with_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Simple_with_Radius
- Brushes_EllipsemaskingEllipseSuperpositionPanel_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseSuperpositionPanel
- Brushes_ImageBrushWithScaleTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithScaleTransform
- Brushes_RectangleStretchFill_Uno_UI_Samples_UITests_ImageBrushTestControl_RectangleStretchFill
- Buttons_AppBar_KeyBoard_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBar_KeyBoard
- Buttons_CheckBox_Button_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_Button
- Buttons_CheckBox_Button_UWA_Style_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_Button_UWA_Style
- Buttons_ToggleSwitch_IsEnable_Automated_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ToggleSwitch_IsEnable_Automated
- Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsBasicPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsBasicPage
- Clipping_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingRoundedCorners_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingRoundedCorners
- Clipping_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingToControlBounds_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingToControlBounds
- ContentControl_ContentControl_NoTemplateDataContext_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_NoTemplateDataContext
- ContentControl_ContentControl_NoTemplateNoContent_SamplesApp_Windows_UI_Xaml_Controls_ContentControlNoTemplateNoContent
- Default_UITests_Toolkit_ElevatedView_Levels_UITests_Toolkit_ElevatedView_Levels
- Default_UITests_Toolkit_ElevatedView_Tester_UITests_Toolkit_ElevatedView_Tester
- DragAndDrop_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_ListView_Custom_States_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_ListView_Custom_States
- DragAndDrop_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TreeView_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TreeView
skia-gtk-screenshots: 35 changed over 1099
🚨🚨 Comparison Details (first 20) 🚨🚨
- ImageSourceUrlMsAppDataScheme.png
- UIElement_ContextFlyout.png
- EllipsemaskingEllipseSuperpositionPanel.png
- MediaPlayerElement_Stretch_Fill.png
- Native.png
- TransformToVisual_Transform.png
- CalendarView_Theming.png
- PipsPagerExamples.png
- Using .ogg.png
- Sources.png
- WinUIColorPickerPage.png
- CompositionVisualSurface.png
- WinUIProgressRingPage.png
- WinUIProgressRing_Features.png
- Ellipse.png
- LargeImageList.png
- CompositionMaskBrush.png
- ProgressRingHeightTest.png
- Using .avi.png
- Using .mov.png
skia-linux-screenshots: 33 changed over 1099
🚨🚨 Comparison Details (first 20) 🚨🚨
- Image_UseTargetSize.png
- Image_Stretch_None.png
- Image_Stretch_None_ScrollViewer.png
- ProgressRingHeightTest.png
- RedirectVisual.png
- ImageBrushAlignmentXY.png
- Ellipse.png
- Mini player.png
- CalendarView_Theming.png
- MediaPlayer.png
- MediaPlayerElement_Stretch_Fill.png
- PipsPagerExamples.png
- ImageBrush_StreamSource.png
- DoubleImageBrushInList.png
- CompositionMaskBrush.png
- ImageBrush_UniformToFill.png
- ImageIconPage.png
- BorderImageBrushRelativeTransform.png
- Using .mkv.png
- Sources.png
skia-windows-screenshots: 16 changed over 1099
🚨🚨 Comparison Details (first 20) 🚨🚨
- ImageBrush_SameWithDelay.png
- ImageIconPage.png
- CalendarView_Theming.png
- CompositionVisualSurface.png
- Native.png
- SvgImageSource_NoSize.png
- SwipeControlPage2.png
- CompositionMaskBrush.png
- Ellipse.png
- PipsPagerExamples.png
- MediaPlayer.png
- WinUIProgressRingPage.png
- WinUIProgressRing_CustomSources.png
- WinUIProgressRing_Features.png
- WindowsProgressRing_GH1220.png
- WinUIColorPickerPage.png
wasm: 82 changed over 1049
🚨🚨 Comparison Details (first 20) 🚨🚨
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Expandable_Item
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Expandable_Item_Large
- UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_3gp_Extension
- UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Avi_Extension
- UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Flv_Extension
- UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal
- UITests.Windows_UI_Xaml.UIElementTests.UIElement_MeasureDirtyPath
- UITests.Windows_UI_Xaml_Controls.Repeater.StackLayout_Simple
- UITests.Windows_UI_Xaml_Controls.Repeater.UniformGridLayout_Simple
- GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode
- MUXControlsTestApp.NavigationViewAnimationPage
- MUXControlsTestApp.PersonPicturePage
- UITests.Microsoft_UI_Xaml_Controls.RefreshContainerTests.RefreshContainerHorizontalScroll
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewWithinScollViewer
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_ItemContainerStyleSelector
- UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
- UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_With_ListViews_Count_Measure
- UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
- Uno.UI.Samples.Content.UITests.FocusTests.FocusManager_GetFocus_Automated
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
wasm-automated-net7.0-UWP-Default-automated: 32 changed over 1955
🚨🚨 Comparison Details (first 20) 🚨🚨
- Default_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage
- Check_ListView_Swallows_Measure_after_scroll
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
- Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- PipsPager_MUXControlsTestApp_PipsPagerExamples_MUXControlsTestApp_PipsPagerExamples
- TextBlock_TextBlock_TextTrimming_VerticalAlignment_Stretch_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_TextTrimming_VerticalAlignment_Stretch
- TextBlock_Uno_UI_Samples_Content_UITests_TextBlockControl_SimpleText_MaxLines_Multiple_Containers_Uno_UI_Samples_Content_UITests_TextBlockControl_SimpleText_MaxLines_Multiple_Containers
- TextBlock_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_BrushColorChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_BrushColorChanging
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- TextBlock_TextBlock_Run_Inheritance_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Run_Inheritance
wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net7.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net7.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net7.0-WinUI-RuntimeTests-2: 0 changed over 1

carldebilly

LGTM

This reverts commit 15a8de8, reversing changes made to 2569bb1.

Revert "Merge pull request #15946 from unoplatform/dev/dr/irVirIssue"

This reverts commit 15a8de8, reversing changes made to 2569bb1. (cherry picked from commit 9cffe01) # Conflicts: # src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater.cs

…5.2/pr-16253 Revert "Merge pull request #15946 from unoplatform/dev/dr/irVirIssue" (backport #16253)

fix(itemsRepeater): Fix an issue where IR might re-position first ite…

08f9b15

…ms if items below are significantly higher

github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Mar 19, 2024

Youssef1313 reviewed Mar 19, 2024

View reviewed changes

src/SamplesApp/UITests.Shared/ItemExclusions.props Show resolved Hide resolved

Youssef1313 reviewed Mar 19, 2024

View reviewed changes

src/Uno.UI/Microsoft/UI/Xaml/Controls/Repeater/StackLayout.cs Show resolved Hide resolved

chore: Spaces

bd033e4

chore: Fix build issue on windows

e5b937d

dr1rrb force-pushed the dev/dr/irVirIssue branch from a9b6d69 to e5b937d Compare March 20, 2024 21:32

test: Disable failing test on platfroms that are no scrolling / rende…

bf5e7dc

…ring synschronously

dr1rrb force-pushed the dev/dr/irVirIssue branch from cd32ed0 to 8b20c0b Compare March 25, 2024 22:06

fix(repeater): Disable non supported animation

032f2f0

dr1rrb force-pushed the dev/dr/irVirIssue branch from 8c44583 to 032f2f0 Compare March 26, 2024 14:21

dr1rrb enabled auto-merge March 26, 2024 15:09

carldebilly approved these changes Mar 26, 2024

View reviewed changes

dr1rrb merged commit 15a8de8 into master Mar 26, 2024
102 checks passed

dr1rrb deleted the dev/dr/irVirIssue branch March 26, 2024 18:55

dr1rrb added a commit that referenced this pull request Apr 12, 2024

Revert "Merge pull request #15946 from unoplatform/dev/dr/irVirIssue"

9cffe01

This reverts commit 15a8de8, reversing changes made to 2569bb1.

This was referenced Apr 12, 2024

Revert "Merge pull request #15946 from unoplatform/dev/dr/irVirIssue" #16253

Merged

[Regression] ItemsRepeater #16176

Closed

dr1rrb added a commit that referenced this pull request Apr 12, 2024

Merge pull request #16253 from unoplatform/dev/dr/revetIrVirIssue

f8937a1

Revert "Merge pull request #15946 from unoplatform/dev/dr/irVirIssue"

mergify bot mentioned this pull request Apr 12, 2024

Revert "Merge pull request #15946 from unoplatform/dev/dr/irVirIssue" (backport #16253) #16265

Merged

jeromelaban added a commit that referenced this pull request Apr 15, 2024

Merge pull request #16265 from unoplatform/mergify/bp/release/stable/…

c5d50f9

…5.2/pr-16253 Revert "Merge pull request #15946 from unoplatform/dev/dr/irVirIssue" (backport #16253)

dr1rrb mentioned this pull request Apr 25, 2024

fix(itemsRepeater): Fix an issue where IR might re-position first items if items below are significantly taller #16472

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(itemsRepeater): Fix an issue where IR might re-position first items if items below are significantly higher #15946

fix(itemsRepeater): Fix an issue where IR might re-position first items if items below are significantly higher #15946

dr1rrb commented Mar 19, 2024

unodevops commented Mar 19, 2024

unodevops commented Mar 20, 2024

unodevops commented Mar 20, 2024

unodevops commented Mar 20, 2024

unodevops commented Mar 20, 2024

unodevops commented Mar 20, 2024

unodevops commented Mar 21, 2024

unodevops commented Mar 21, 2024

dr1rrb commented Mar 22, 2024

azure-pipelines bot commented Mar 22, 2024

unodevops commented Mar 22, 2024

unodevops commented Mar 22, 2024

unodevops commented Mar 25, 2024

unodevops commented Mar 25, 2024

unodevops commented Mar 25, 2024

unodevops commented Mar 25, 2024

unodevops commented Mar 26, 2024

unodevops commented Mar 26, 2024

nventive-devops commented Mar 26, 2024

carldebilly left a comment

fix(itemsRepeater): Fix an issue where IR might re-position first items if items below are significantly higher #15946

fix(itemsRepeater): Fix an issue where IR might re-position first items if items below are significantly higher #15946

Conversation

dr1rrb commented Mar 19, 2024

Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

unodevops commented Mar 19, 2024

unodevops commented Mar 20, 2024

unodevops commented Mar 20, 2024

unodevops commented Mar 20, 2024

unodevops commented Mar 20, 2024

unodevops commented Mar 20, 2024

unodevops commented Mar 21, 2024

unodevops commented Mar 21, 2024

dr1rrb commented Mar 22, 2024

azure-pipelines bot commented Mar 22, 2024

unodevops commented Mar 22, 2024

unodevops commented Mar 22, 2024

unodevops commented Mar 25, 2024

unodevops commented Mar 25, 2024

unodevops commented Mar 25, 2024

unodevops commented Mar 25, 2024

unodevops commented Mar 26, 2024

unodevops commented Mar 26, 2024

nventive-devops commented Mar 26, 2024

carldebilly left a comment

Choose a reason for hiding this comment